improvements on validating properties

Author: Matias Melograno

splitio/client/input_validator.py

@@ -485,15 +485,12 @@ def valid_properties(properties):
         _LOGGER.error('track: properties must be of type dictionary.')
         return False, None, 0
 
-    valid_properties = None
+    valid_properties = dict()
 
     for property, element in properties.items():
         if not isinstance(property, six.string_types):  # Exclude property if is not string
             continue
 
-        if valid_properties is None:
-            valid_properties = dict()
-
         valid_properties[property] = None
         size += len(property)
 
@@ -517,7 +514,7 @@ def valid_properties(properties):
             )
             return False, None, size
 
-    if isinstance(valid_properties, dict) and len(valid_properties.keys()) > 300:
+    if len(valid_properties.keys()) > 300:
         _LOGGER.warning('Event has more than 300 properties. Some of them will be trimmed' +
                         ' when processed')
-    return True, valid_properties, size
+    return True, valid_properties if len(valid_properties.keys()) > 0 else None, size

tests/client/test_input_validator.py

@@ -451,7 +451,14 @@ def test_valid_properties(self, mocker):
         assert input_validator.valid_properties(None) == (True, None, 1024)
         assert input_validator.valid_properties([]) == (False, None, 0)
         assert input_validator.valid_properties(True) == (False, None, 0)
-
+        assert input_validator.valid_properties(dict()) == (True, None, 1024)
+        assert input_validator.valid_properties({ 2: 123 }) == (True, None, 1024)
+
+        class Test:
+            pass
+        assert input_validator.valid_properties({
+            "test": Test()
+        }) == (True, { "test": None }, 1028)
 
         props1 = {
             "test1": "test",