Merge pull request #619 from splitio/FME-12322-fix-redis-prefix

ignored fetching rbs if list is empty

Author: chillaq

splitio/storage/redis.py

@@ -142,6 +142,9 @@ def fetch_many(self, segment_names):
         :rtype: dict(segment_name, splitio.models.rule_based_segment.RuleBasedSegment)
         """
         to_return = dict()
+        if len(segment_names) == 0:
+            return to_return
+        
         try:
             keys = [self._get_key(segment_name) for segment_name in segment_names]
             raw_rbs_segments = self._redis.mget(keys)
@@ -286,6 +289,9 @@ async def fetch_many(self, segment_names):
         :rtype: dict(segment_name, splitio.models.rule_based_segment.RuleBasedSegment)
         """
         to_return = dict()
+        if len(segment_names) == 0:
+            return to_return
+
         try:
             keys = [self._get_key(segment_name) for segment_name in segment_names]
             raw_rbs_segments = await self._redis.mget(keys)

tests/storage/test_redis.py

@@ -1315,6 +1315,10 @@ def test_fetch_many(self, mocker):
         assert result['rbs2'] is not None
         assert 'rbs3' in result
 
+        # should not raise exception
+        result = storage.fetch_many([])
+        assert len(result) == 0
+
 class RedisRuleBasedSegmentStorageAsyncTests(object):
     """Redis rule based segment storage test cases."""
 
@@ -1438,3 +1442,7 @@ async def mget(*_):
         assert result['rbs2'] is not None
         assert 'rbs3' in result
 
+        # should not raise exception
+        result = await storage.fetch_many([])
+        assert len(result) == 0
+