Skip to content

Commit 3913119

Browse files
author
Matias Melograno
committed
renamed post fork method
1 parent 7fa443f commit 3913119

File tree

4 files changed

+8
-8
lines changed

4 files changed

+8
-8
lines changed

CHANGES.txt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
1-
8.3.2 (Dec XX, 2020)
1+
8.3.2 (Dec 21, 2020)
22
- Added RecordStats for supporting pipelined recording in redis when treatment call is made.
3-
- Added hooks support for UWSGI.
3+
- Added hooks support for preforked servers.
44

55
8.3.1 (Nov 20, 2020)
66
- Fixed error handling when split server fails, so that it doesn't bring streaming down.

splitio/client/factory.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -254,12 +254,12 @@ def _waiting_fork(self):
254254
"""
255255
return self._status == Status.WAITING_FORK
256256

257-
def handle_post_fork(self):
257+
def resume(self):
258258
"""
259259
Function in charge of starting periodic/realtime synchronization after a fork.
260260
"""
261261
if not self._waiting_fork():
262-
_LOGGER.warning('Cannot call handle_post_fork')
262+
_LOGGER.warning('Cannot call resume')
263263
return
264264
self._sync_manager.recreate()
265265
sdk_ready_flag = threading.Event()

splitio/version.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
__version__ = '8.3.2-rc5'
1+
__version__ = '8.3.2-rc6'

tests/client/test_factory.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -539,7 +539,7 @@ def _get_storage_mock(self, name):
539539
assert len(sync_all_mock.mock_calls) == 1
540540
assert len(start_mock.mock_calls) == 0
541541

542-
factory.handle_post_fork()
542+
factory.resume()
543543
assert len(recreate_mock.mock_calls) == 1
544544
assert len(start_mock.mock_calls) == 1
545545

@@ -550,7 +550,7 @@ def _get_storage_mock(self, name):
550550
def test_error_prefork(self, mocker):
551551
"""Test not handling fork."""
552552
expected_msg = [
553-
mocker.call('Cannot call handle_post_fork')
553+
mocker.call('Cannot call resume')
554554
]
555555

556556
filename = os.path.join(os.path.dirname(__file__), '../integration/files', 'file2.yaml')
@@ -559,5 +559,5 @@ def test_error_prefork(self, mocker):
559559

560560
_logger = mocker.Mock()
561561
mocker.patch('splitio.client.factory._LOGGER', new=_logger)
562-
factory.handle_post_fork()
562+
factory.resume()
563563
assert _logger.warning.mock_calls == expected_msg

0 commit comments

Comments
 (0)