polish

Author: chillaq

splitio/sync/manager.py

@@ -142,13 +142,10 @@ class ManagerAsync(object):  # pylint:disable=too-many-instance-attributes
 
     _CENTINEL_EVENT = object()
 
-    def __init__(self, ready_flag, synchronizer, auth_api, streaming_enabled, sdk_metadata, telemetry_runtime_producer, sse_url=None, client_key=None):  # pylint:disable=too-many-arguments
+    def __init__(self, synchronizer, auth_api, streaming_enabled, sdk_metadata, telemetry_runtime_producer, sse_url=None, client_key=None):  # pylint:disable=too-many-arguments
         """
         Construct Manager.
 
-        :param ready_flag: Flag to set when splits initial sync is complete.
-        :type ready_flag: threading.Event
-
         :param split_synchronizers: synchronizers for performing start/stop logic
         :type split_synchronizers: splitio.sync.synchronizer.Synchronizer
 

tests/sync/test_manager.py

@@ -117,7 +117,7 @@ async def get_change_number():
                                            mocker.Mock(), mocker.Mock(), mocker.Mock())
 
         synchronizer = SynchronizerAsync(synchronizers, split_tasks)
-        manager = ManagerAsync(asyncio.Event(), synchronizer,  mocker.Mock(), False, SdkMetadata('1.0', 'some', '1.2.3.4'), mocker.Mock())
+        manager = ManagerAsync(synchronizer,  mocker.Mock(), False, SdkMetadata('1.0', 'some', '1.2.3.4'), mocker.Mock())
 
         manager._SYNC_ALL_ATTEMPTS = 1
         await manager.start(2)  # should not throw!
@@ -140,7 +140,7 @@ def start_periodic_data_recording():
             self.rcording_called += 1
         synchronizer.start_periodic_data_recording = start_periodic_data_recording
 
-        manager = ManagerAsync(mocker.Mock(), synchronizer, mocker.Mock(), False, SdkMetadata('1.0', 'some', '1.2.3.4'), mocker.Mock())
+        manager = ManagerAsync(synchronizer, mocker.Mock(), False, SdkMetadata('1.0', 'some', '1.2.3.4'), mocker.Mock())
         try:
             await manager.start()
         except:
@@ -163,7 +163,7 @@ async def stop_periodic_fetching():
         telemetry_storage = await InMemoryTelemetryStorageAsync.create()
         telemetry_producer = TelemetryStorageProducerAsync(telemetry_storage)
         telemetry_runtime_producer = telemetry_producer.get_telemetry_runtime_producer()
-        manager = ManagerAsync(mocker.Mock(), synchronizer, mocker.Mock(), True, SdkMetadata('1.0', 'some', '1.2.3.4'), telemetry_runtime_producer)
+        manager = ManagerAsync(synchronizer, mocker.Mock(), True, SdkMetadata('1.0', 'some', '1.2.3.4'), telemetry_runtime_producer)
         try:
             await manager.start()
         except: