Skip to content

Commit 4ddbd24

Browse files
committed
Fixed bloomfilter class name
1 parent daddae4 commit 4ddbd24

File tree

4 files changed

+37
-11
lines changed

4 files changed

+37
-11
lines changed

setup.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
'flake8',
99
'pytest==7.0.1',
1010
'pytest-mock>=3.5.1',
11-
'coverage==6.1',
11+
'coverage==6.2',
1212
'pytest-cov',
1313
'importlib-metadata==4.2',
1414
'tomli==1.2.3',

splitio/engine/filters/__init__.py

Lines changed: 28 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,28 @@
1+
import abc
2+
3+
class BaseFilter(object, metaclass=abc.ABCMeta):
4+
"""Impressions Filter interface."""
5+
6+
@abc.abstractmethod
7+
def add(self, data):
8+
"""
9+
Return a boolean flag
10+
11+
"""
12+
pass
13+
14+
@abc.abstractmethod
15+
def contains(self, data):
16+
"""
17+
Return a boolean flag
18+
19+
"""
20+
pass
21+
22+
@abc.abstractmethod
23+
def clear(self):
24+
"""
25+
No return
26+
27+
"""
28+
pass

splitio/engine/filters/bloom_filter.py

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,7 @@
1-
from splitio.engine.filters.base_filter import BaseFilter
2-
from splitio import util
3-
from bloom_filter2 import BloomFilter
1+
from splitio.engine.filters import BaseFilter
2+
from bloom_filter2 import BloomFilter as BloomFilter2
43

5-
class ImpressionsBloomFilter(BaseFilter):
4+
class BloomFilter(BaseFilter):
65
"""Optimized mode strategy."""
76

87
def __init__(self, max_elements=5000, error_rate=0.01):
@@ -17,7 +16,7 @@ def __init__(self, max_elements=5000, error_rate=0.01):
1716
"""
1817
self._max_elements = max_elements
1918
self._error_rate = error_rate
20-
self._imps_bloom_filter = BloomFilter(max_elements=self._max_elements, error_rate=self._error_rate)
19+
self._imps_bloom_filter = BloomFilter2(max_elements=self._max_elements, error_rate=self._error_rate)
2120

2221
def add(self, data):
2322
"""
@@ -50,4 +49,4 @@ def clear(self):
5049
5150
"""
5251
self._imps_bloom_filter.close()
53-
self._imps_bloom_filter = BloomFilter(max_elements=self._max_elements, error_rate=self._error_rate)
52+
self._imps_bloom_filter = BloomFilter2(max_elements=self._max_elements, error_rate=self._error_rate)

tests/engine/test_bloom_filter.py

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,14 +2,13 @@
22

33
from random import random
44
import uuid
5-
import time
6-
from splitio.engine.filters.bloom_filter import ImpressionsBloomFilter
5+
from splitio.engine.filters.bloom_filter import BloomFilter
76

87
class BloomFilterTests(object):
98
"""StandardRecorderTests test cases."""
109

1110
def test_bloom_filter_methods(self, mocker):
12-
bloom_filter = ImpressionsBloomFilter()
11+
bloom_filter = BloomFilter()
1312
key1 = str(uuid.uuid4())
1413
key2 = str(uuid.uuid4())
1514
bloom_filter.add(key1)
@@ -29,7 +28,7 @@ def test_bloom_filter_error_percentage(self, mocker):
2928
arr_storage = []
3029
total_sample = 20000
3130
error_rate = 0.01
32-
bloom_filter = ImpressionsBloomFilter(total_sample, error_rate)
31+
bloom_filter = BloomFilter(total_sample, error_rate)
3332

3433
for x in range(1, total_sample):
3534
myuuid = str(uuid.uuid4())

0 commit comments

Comments
 (0)