polishing

Author: chillaq

splitio/client/client.py

@@ -292,7 +292,6 @@ def _get_treatment(self, method, key, feature, attributes=None):
                 result = self._evaluator.eval_with_context(key, bucketing, feature, attributes, ctx)
             except Exception as e: # toto narrow this
                 _LOGGER.error('Error getting treatment for feature flag')
-                _LOGGER.error(str(e))
                 _LOGGER.debug('Error: ', exc_info=True)
                 self._telemetry_evaluation_producer.record_exception(method)
                 result = self._FAILED_EVAL_RESULT
@@ -382,7 +381,6 @@ def _get_treatments(self, key, features, method, attributes=None):
                 results = self._evaluator.eval_many_with_context(key, bucketing, features, attributes, ctx)
             except Exception as e: # toto narrow this
                 _LOGGER.error('Error getting treatment for feature flag')
-                _LOGGER.error(str(e))
                 _LOGGER.debug('Error: ', exc_info=True)
                 self._telemetry_evaluation_producer.record_exception(method)
                 results = {n: self._FAILED_EVAL_RESULT for n in features}
@@ -572,7 +570,6 @@ async def _get_treatment(self, method, key, feature, attributes=None):
                 result = self._evaluator.eval_with_context(key, bucketing, feature, attributes, ctx)
             except Exception as e: # toto narrow this
                 _LOGGER.error('Error getting treatment for feature flag')
-                _LOGGER.error(str(e))
                 _LOGGER.debug('Error: ', exc_info=True)
                 await self._telemetry_evaluation_producer.record_exception(method)
                 result = self._FAILED_EVAL_RESULT
@@ -662,7 +659,6 @@ async def _get_treatments(self, key, features, method, attributes=None):
                 results = self._evaluator.eval_many_with_context(key, bucketing, features, attributes, ctx)
             except Exception as e: # toto narrow this
                 _LOGGER.error('Error getting treatment for feature flag')
-                _LOGGER.error(str(e))
                 _LOGGER.debug('Error: ', exc_info=True)
                 await self._telemetry_evaluation_producer.record_exception(method)
                 results = {n: self._FAILED_EVAL_RESULT for n in features}

splitio/client/factory.py

@@ -410,7 +410,7 @@ async def block_until_ready(self, timeout=None):
             await asyncio.wait_for(asyncio.shield(self._sdk_ready_flag.wait()), timeout)
         except asyncio.TimeoutError as e:
             _LOGGER.error("Exception initializing SDK")
-            _LOGGER.error(str(e))
+            _LOGGER.debug(str(e))
             await self._telemetry_init_producer.record_bur_time_out()
             raise TimeoutException('SDK Initialization: time of %d exceeded' % timeout)
 

splitio/push/workers.py

@@ -23,6 +23,12 @@ class CompressionMode(Enum):
     GZIP_COMPRESSION = 1
     ZLIB_COMPRESSION = 2
 
+_compression_handlers = {
+    CompressionMode.NO_COMPRESSION: lambda event: base64.b64decode(event.feature_flag_definition),
+    CompressionMode.GZIP_COMPRESSION: lambda event: gzip.decompress(base64.b64decode(event.feature_flag_definition)).decode('utf-8'),
+    CompressionMode.ZLIB_COMPRESSION: lambda event: zlib.decompress(base64.b64decode(event.feature_flag_definition)).decode('utf-8'),
+}
+
 class WorkerBase(object, metaclass=abc.ABCMeta):
     """Worker template."""
 
@@ -41,7 +47,7 @@ def stop(self):
     def _get_feature_flag_definition(self, event):
         """return feature flag definition in event."""
         cm = CompressionMode(event.compression) # will throw if the number is not defined in compression mode
-        return self._compression_handlers[cm](event)
+        return _compression_handlers[cm](event)
 
 class SegmentWorker(WorkerBase):
     """Segment Worker for processing updates."""
@@ -190,11 +196,6 @@ def __init__(self, synchronize_feature_flag, synchronize_segment, feature_flag_q
         self._worker = None
         self._feature_flag_storage = feature_flag_storage
         self._segment_storage = segment_storage
-        self._compression_handlers = {
-            CompressionMode.NO_COMPRESSION: lambda event: base64.b64decode(event.feature_flag_definition),
-            CompressionMode.GZIP_COMPRESSION: lambda event: gzip.decompress(base64.b64decode(event.feature_flag_definition)).decode('utf-8'),
-            CompressionMode.ZLIB_COMPRESSION: lambda event: zlib.decompress(base64.b64decode(event.feature_flag_definition)).decode('utf-8'),
-        }
         self._telemetry_runtime_producer = telemetry_runtime_producer
 
     def is_running(self):
@@ -233,13 +234,11 @@ def _run(self):
                         continue
                     except Exception as e:
                         _LOGGER.error('Exception raised in updating feature flag')
-                        _LOGGER.debug(str(e))
                         _LOGGER.debug('Exception information: ', exc_info=True)
                         pass
                 self._handler(event.change_number)
             except Exception as e:  # pylint: disable=broad-except
                 _LOGGER.error('Exception raised in feature flag synchronization')
-                _LOGGER.debug(str(e))
                 _LOGGER.debug('Exception information: ', exc_info=True)
 
     def start(self):
@@ -290,11 +289,6 @@ def __init__(self, synchronize_feature_flag, synchronize_segment, feature_flag_q
         self._running = False
         self._feature_flag_storage = feature_flag_storage
         self._segment_storage = segment_storage
-        self._compression_handlers = {
-            CompressionMode.NO_COMPRESSION: lambda event: base64.b64decode(event.feature_flag_definition),
-            CompressionMode.GZIP_COMPRESSION: lambda event: gzip.decompress(base64.b64decode(event.feature_flag_definition)).decode('utf-8'),
-            CompressionMode.ZLIB_COMPRESSION: lambda event: zlib.decompress(base64.b64decode(event.feature_flag_definition)).decode('utf-8'),
-        }
         self._telemetry_runtime_producer = telemetry_runtime_producer
 
     def is_running(self):
@@ -333,13 +327,11 @@ async def _run(self):
                         continue
                     except Exception as e:
                         _LOGGER.error('Exception raised in updating feature flag')
-                        _LOGGER.debug(str(e))
                         _LOGGER.debug('Exception information: ', exc_info=True)
                         pass
                 await self._handler(event.change_number)
             except Exception as e:  # pylint: disable=broad-except
                 _LOGGER.error('Exception raised in split synchronization')
-                _LOGGER.debug(str(e))
                 _LOGGER.debug('Exception information: ', exc_info=True)
 
     def start(self):

splitio/sync/telemetry.py

@@ -1,10 +1,6 @@
 """Telemetry Sync Class."""
 import abc
 
-from splitio.api.telemetry import TelemetryAPI
-from splitio.engine.telemetry import TelemetryStorageConsumer
-from splitio.models.telemetry import UpdateFromSSE
-
 class TelemetrySynchronizer(object):
     """Telemetry synchronizer class."""