support lowercase impressions mode

Author: mredolatti

splitio/client/config.py

@@ -2,10 +2,14 @@
 from __future__ import absolute_import, division, print_function, unicode_literals
 
 import os.path
+import logging
 
 from splitio.engine.impressions import ImpressionsMode
 
 
+_LOGGER = logging.getLogger(__name__)
+
+
 DEFAULT_CONFIG = {
     'operationMode': 'in-memory',
     'connectionTimeout': 1500,
@@ -87,8 +91,9 @@ def _sanitize_impressions_mode(mode, refresh_rate=None):
     """
     if not isinstance(mode, ImpressionsMode):
         try:
-            mode = ImpressionsMode(mode)
-        except ValueError:
+            mode = ImpressionsMode(mode.upper())
+        except (ValueError, AttributeError):
+            _LOGGER.warning('unrecognized impressionsMode supplied. Defaulting to OPTIMIZED')
             mode = ImpressionsMode.OPTIMIZED
 
     if mode == ImpressionsMode.DEBUG:

tests/client/test_config.py

@@ -25,6 +25,10 @@ def test_sanitize_imp_mode(self):
         assert mode == ImpressionsMode.DEBUG
         assert rate == 1
 
+        mode, rate = config._sanitize_impressions_mode('debug', 1)
+        assert mode == ImpressionsMode.DEBUG
+        assert rate == 1
+
         mode, rate = config._sanitize_impressions_mode('ANYTHING', 200)
         assert mode == ImpressionsMode.OPTIMIZED
         assert rate == 200