Merge branch 'feature/mtkTracking' into NoneImplementation

Author: chillaq

splitio/client/factory.py

@@ -334,6 +334,14 @@ def _build_in_memory_factory(api_key, cfg, sdk_url=None, events_url=None,  # pyl
     }
     imp_strategy = strategies[cfg['impressionsMode']]
 
+    imp_counter = ImpressionsCounter() if cfg['impressionsMode'] != ImpressionsMode.DEBUG else None
+
+    strategies = {
+        ImpressionsMode.OPTIMIZED : StrategyOptimizedMode(imp_counter),
+        ImpressionsMode.DEBUG : StrategyDebugMode(),
+    }
+    imp_strategy = strategies[cfg['impressionsMode']]
+
     imp_manager = ImpressionsManager(
         _wrap_impression_listener(cfg['impressionListener'], sdk_metadata),
         imp_strategy)
@@ -346,6 +354,7 @@ def _build_in_memory_factory(api_key, cfg, sdk_url=None, events_url=None,  # pyl
         EventSynchronizer(apis['events'], storages['events'], cfg['eventsBulkSize']),
         ImpressionsCountSynchronizer(apis['impressions'], imp_manager),
     )
+    imp_count_sync_task = ImpressionsCountSyncTask(synchronizers.impressions_count_sync.synchronize_counters) if cfg['impressionsMode'] == 'OPTIMIZED' else None
 
     tasks = SplitTasks(
         SplitSynchronizationTask(
@@ -443,7 +452,6 @@ def _build_redis_factory(api_key, cfg):
         recorder,
     )
 
-
 def _build_localhost_factory(cfg):
     """Build and return a localhost factory for testing/development purposes."""
     storages = {
@@ -470,6 +478,7 @@ def _build_localhost_factory(cfg):
     synchronizer = LocalhostSynchronizer(synchronizers, tasks)
     manager = Manager(ready_event, synchronizer, None, False, sdk_metadata)
     manager.start()
+
     recorder = StandardRecorder(
         ImpressionsManager(None, StrategyDebugMode()),
         storages['events'],

splitio/engine/strategies/strategy_optimized_mode.py

@@ -15,7 +15,6 @@ def __init__(self, counter):
         self._observer = Observer(_IMPRESSION_OBSERVER_CACHE_SIZE)
         self._counter = counter
 
-
     def process_impressions(self, impressions):
         """
         Process impressions.

splitio/sync/impression.py

@@ -2,6 +2,7 @@
 import queue
 
 from splitio.api import APIException
+from splitio.engine.strategies import Counter
 
 
 _LOGGER = logging.getLogger(__name__)
@@ -68,18 +69,18 @@ def synchronize_impressions(self):
 
 
 class ImpressionsCountSynchronizer(object):
-    def __init__(self, impressions_api, impressions_manager):
+    def __init__(self, impressions_api, impressions_counter):
         """
         Class constructor.
 
         :param impressions_api: Impressions Api object to send data to the backend
         :type impressions_api: splitio.api.impressions.ImpressionsAPI
         :param impressions_manager: Impressions manager instance
-        :type impressions_manager: splitio.engine.impressions.Manager
+        :type impressions_counter: splitio.engine.strategies
 
         """
         self._impressions_api = impressions_api
-        self._impressions_manager = impressions_manager
+        self._impressions_counter = impressions_counter
 
     def synchronize_counters(self):
         """Send impressions from both the failed and new queues."""

splitio/sync/synchronizer.py

@@ -367,6 +367,7 @@ def stop_periodic_data_recording(self, blocking):
             if self._split_tasks.unique_keys_task is not None:
                 tasks.append(self._split_tasks.unique_keys_task)
                 tasks.append(self._split_tasks.clear_filter_task)
+
             for task in tasks:
                 stop_event = threading.Event()
                 task.stop(stop_event)

tests/integration/test_client_e2e.py

@@ -21,7 +21,6 @@
 from splitio.recorder.recorder import StandardRecorder, PipelinedRecorder
 from splitio.client.config import DEFAULT_CONFIG
 
-
 class InMemoryIntegrationTests(object):
     """Inmemory storage-based integration tests."""
 

tests/tasks/test_impressions_sync.py

@@ -12,7 +12,6 @@
 from splitio.engine.strategies import Counter
 from splitio.engine.strategies.strategy_optimized_mode import StrategyOptimizedMode
 
-
 class ImpressionsSyncTests(object):
     """Impressions Syncrhonization task test cases."""