fixed test and added clear coverage

Author: Matias Melograno

tests/client/test_client.py

@@ -378,12 +378,15 @@ def _get_storage_mock(name):
         factory._get_storage = _get_storage_mock
         destroyed_mock = mocker.PropertyMock()
         destroyed_mock.return_value = False
+        factory._waiting_fork.return_value = False
         type(factory).destroyed = destroyed_mock
         factory._apikey = 'test'
         mocker.patch('splitio.client.client.utctime_ms', new=lambda: 1000)
 
         impmanager = mocker.Mock(spec=ImpressionManager)
-        client = Client(factory, impmanager, True)
+        recorder = StandardRecorder(impmanager, telemetry_storage, event_storage,
+                                    impression_storage)
+        client = Client(factory, recorder, True)
         assert client.track('key', 'user', 'purchase', 12) is True
         assert mocker.call([
             EventWrapper(

tests/client/test_factory.py

@@ -486,6 +486,39 @@ def _make_factory_with_apikey(apikey, *_, **__):
 
     def test_uwsgi_preforked(self, mocker):
         """Test preforked initializations."""
+
+        def clear_impressions():
+            clear_impressions._called += 1
+
+        def clear_events():
+            clear_events._called += 1
+
+        def clear_telemetry():
+            clear_telemetry._called += 1
+
+        clear_impressions._called = 0
+        clear_events._called = 0
+        clear_telemetry._called = 0
+        split_storage = mocker.Mock(spec=inmemmory.SplitStorage)
+        segment_storage = mocker.Mock(spec=inmemmory.SegmentStorage)
+        impression_storage = mocker.Mock(spec=inmemmory.ImpressionStorage)
+        impression_storage.clear.side_effect = clear_impressions
+        event_storage = mocker.Mock(spec=inmemmory.EventStorage)
+        event_storage.clear.side_effect = clear_events
+        telemetry_storage = mocker.Mock(spec=inmemmory.TelemetryStorage)
+        telemetry_storage.clear.side_effect = clear_telemetry
+
+        def _get_storage_mock(self, name):
+            return {
+                'splits': split_storage,
+                'segments': segment_storage,
+                'impressions': impression_storage,
+                'events': event_storage,
+                'telemetry': telemetry_storage
+            }[name]
+
+        mocker.patch('splitio.client.factory.SplitFactory._get_storage', new=_get_storage_mock)
+
         global called_sync_all
         called_sync_all = 0
         global called_start
@@ -495,7 +528,6 @@ def test_uwsgi_preforked(self, mocker):
 
         # Mocking
         def _sync_all(self):
-            print('here')
             global called_sync_all
             called_sync_all += 1
         mocker.patch('splitio.sync.synchronizer.Synchronizer.sync_all', new=_sync_all)
@@ -522,3 +554,7 @@ def _recreate(self):
         factory.handle_post_fork()
         assert called_recreate == 1
         assert called_start == 1
+
+        assert clear_impressions._called == 1
+        assert clear_events._called == 1
+        assert clear_telemetry._called == 1

tests/storage/test_inmemory_storage.py

@@ -307,6 +307,15 @@ def test_queue_full_hook(self, mocker):
         storage.put(impressions)
         assert queue_full_hook.mock_calls == mocker.call()
 
+    def test_clear(self):
+        """Test clear method."""
+        storage = InMemoryImpressionStorage(100)
+        storage.put([Impression('key1', 'feature1', 'on', 'l1', 123456, 'b1', 321654)])
+
+        assert storage._impressions.qsize() == 1
+        storage.clear()
+        assert storage._impressions.qsize() == 0
+
 
 class InMemoryEventsStorageTests(object):
     """InMemory events storage test cases."""
@@ -372,6 +381,18 @@ def test_queue_full_hook_properties(self, mocker):
         storage.put(events)
         assert queue_full_hook.mock_calls == [mocker.call()]
 
+    def test_clear(self):
+        """Test clear method."""
+        storage = InMemoryEventStorage(100)
+        storage.put([EventWrapper(
+            event=Event('key1', 'user', 'purchase', 3.5, 123456, None),
+            size=1024,
+        )])
+
+        assert storage._events.qsize() == 1
+        storage.clear()
+        assert storage._events.qsize() == 0
+
 
 class InMemoryTelemetryStorageTests(object):
     """In-Memory telemetry storage unit tests."""
@@ -413,3 +434,20 @@ def test_gauges(self):
         assert gauges['some_gauge_1'] == 321
         assert gauges['some_gauge_2'] == 654
         assert storage.pop_gauges() == {}
+
+    def test_clear(self):
+        """Test clear."""
+        storage = InMemoryTelemetryStorage()
+        storage.put_gauge('some_gauge_1', 321)
+        storage.inc_counter('some_counter_1')
+        storage.inc_latency('sdk.get_treatment', 5)
+
+        assert len(storage._counters) == 1
+        assert len(storage._gauges) == 1
+        assert len(storage._latencies) == 1
+
+        storage.clear()
+
+        assert len(storage._counters) == 0
+        assert len(storage._gauges) == 0
+        assert len(storage._latencies) == 0