update storage helper

Author: chillaq

splitio/util/storage_helper.py

@@ -88,6 +88,34 @@ async def update_feature_flag_storage_async(feature_flag_storage, feature_flags,
     await feature_flag_storage.update(to_add, to_delete, change_number)
     return segment_list
 
+async def update_rule_based_segment_storage_async(rule_based_segment_storage, rule_based_segments, change_number):
+    """
+    Update rule based segment storage from given list of rule based segments
+
+    :param rule_based_segment_storage: rule based segment storage instance
+    :type rule_based_segment_storage: splitio.storage.RuleBasedSegmentStorage
+    :param rule_based_segments: rule based segment instance to validate.
+    :type rule_based_segments: splitio.models.rule_based_segments.RuleBasedSegment
+    :param: last change number
+    :type: int
+
+    :return: segments list from excluded segments list
+    :rtype: list(str)
+    """
+    segment_list = set()
+    to_add = []
+    to_delete = []
+    for rule_based_segment in rule_based_segments:
+        if rule_based_segment.status == "ACTIVE":
+            to_add.append(rule_based_segment)
+            segment_list.update(set(rule_based_segment.excluded.get_excluded_segments()))
+        else:
+            if await rule_based_segment_storage.get(rule_based_segment.name) is not None:
+                to_delete.append(rule_based_segment.name)
+
+    await rule_based_segment_storage.update(to_add, to_delete, change_number)
+    return segment_list
+
 def get_valid_flag_sets(flag_sets, flag_set_filter):
     """
     Check each flag set in given array, return it if exist in a given config flag set array, if config array is empty return all

tests/storage/test_inmemory_storage.py

@@ -2,6 +2,7 @@
 # pylint: disable=no-self-use
 import random
 import pytest
+import copy
 
 from splitio.models.splits import Split
 from splitio.models.segments import Segment
@@ -13,6 +14,7 @@
     InMemoryImpressionStorage, InMemoryEventStorage, InMemoryTelemetryStorage, InMemoryImpressionStorageAsync, InMemoryEventStorageAsync, \
     InMemoryTelemetryStorageAsync, FlagSets, InMemoryRuleBasedSegmentStorage, InMemoryRuleBasedSegmentStorageAsync
 from splitio.models.rule_based_segments import RuleBasedSegment
+from splitio.models import rule_based_segments
 
 class FlagSetsFilterTests(object):
     """Flag sets filter storage tests."""
@@ -1840,6 +1842,31 @@ def test_store_get_changenumber(self):
         assert storage.get_change_number() == -1
         storage.update([], [], 5)
         assert storage.get_change_number() == 5
+        
+    def test_contains(self):
+        raw = {
+            "changeNumber": 123,
+            "name": "segment1",
+            "status": "ACTIVE",
+            "trafficTypeName": "user",
+            "excluded":{
+            "keys":[],
+            "segments":[]
+            },
+            "conditions": []
+        }
+        segment1 =  rule_based_segments.from_raw(raw)  
+        raw2 = copy.deepcopy(raw)
+        raw2["name"] = "segment2"
+        segment2 =  rule_based_segments.from_raw(raw2)
+        raw3 = copy.deepcopy(raw)
+        raw3["name"] = "segment3"
+        segment3 =  rule_based_segments.from_raw(raw3)
+        storage = InMemoryRuleBasedSegmentStorage()
+        storage.update([segment1, segment2, segment3], [], -1)
+        assert storage.contains(["segment1"])
+        assert storage.contains(["segment1", "segment3"])
+        assert not storage.contains(["segment5"])
 
 class InMemoryRuleBasedSegmentStorageAsyncTests(object):
     """In memory rule based segment storage test cases."""
@@ -1874,3 +1901,29 @@ async def test_store_get_changenumber(self):
         assert await storage.get_change_number() == -1
         await storage.update([], [], 5)
         assert await storage.get_change_number() == 5
+
+    @pytest.mark.asyncio
+    async def test_contains(self):
+        raw = {
+            "changeNumber": 123,
+            "name": "segment1",
+            "status": "ACTIVE",
+            "trafficTypeName": "user",
+            "excluded":{
+            "keys":[],
+            "segments":[]
+            },
+            "conditions": []
+        }
+        segment1 =  rule_based_segments.from_raw(raw)  
+        raw2 = copy.deepcopy(raw)
+        raw2["name"] = "segment2"
+        segment2 =  rule_based_segments.from_raw(raw2)
+        raw3 = copy.deepcopy(raw)
+        raw3["name"] = "segment3"
+        segment3 =  rule_based_segments.from_raw(raw3)
+        storage = InMemoryRuleBasedSegmentStorageAsync()
+        await storage.update([segment1, segment2, segment3], [], -1)
+        assert await storage.contains(["segment1"])
+        assert await storage.contains(["segment1", "segment3"])
+        assert not await storage.contains(["segment5"])