Skip to content

Commit ddbb852

Browse files
committed
remove old legacy test
1 parent eeec9ae commit ddbb852

File tree

1 file changed

+0
-19
lines changed

1 file changed

+0
-19
lines changed

tests/engine/test_hashfns.py

Lines changed: 0 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -33,25 +33,6 @@ def test_legacy_hash_ascii_data(self):
3333
assert hashfns.legacy.legacy_hash(key, seed) == hashed
3434
assert splitter.get_bucket(key, seed, splits.HashAlgorithm.LEGACY) == bucket
3535

36-
@pytest.mark.skipif(six.PY3, reason='Should skip this on python3.')
37-
def test_legacy_hash_non_ascii_data(self):
38-
"""Test legacy hash function against known results."""
39-
splitter = splitters.Splitter()
40-
file_name = os.path.join(
41-
os.path.dirname(__file__),
42-
'files',
43-
'sample-data-non-alpha-numeric.jsonl'
44-
)
45-
with open(file_name, 'r') as flo:
46-
lines = flo.read().split('\n')
47-
48-
for line in lines:
49-
if line is None or line == '':
50-
continue
51-
seed, key, hashed, bucket = json.loads(line)
52-
assert hashfns.legacy.legacy_hash(key, seed) == hashed
53-
assert splitter.get_bucket(key, seed, splits.HashAlgorithm.LEGACY) == bucket
54-
5536
def test_murmur_hash_ascii_data(self):
5637
"""Test legacy hash function against known results."""
5738
splitter = splitters.Splitter()

0 commit comments

Comments
 (0)