Skip to content

Commit f064b94

Browse files
committed
Revert strategy to debug mode for redis
1 parent 847fb5d commit f064b94

File tree

4 files changed

+3
-7
lines changed

4 files changed

+3
-7
lines changed

splitio/client/factory.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -399,10 +399,9 @@ def _build_redis_factory(api_key, cfg):
399399
_MIN_DEFAULT_DATA_SAMPLING_ALLOWED)
400400
data_sampling = _MIN_DEFAULT_DATA_SAMPLING_ALLOWED
401401

402-
imp_strategy = StrategyOptimizedMode(Counter()) if cfg['impressionsMode'] == 'OPTIMIZED' else StrategyDebugMode()
403402
imp_manager = ImpressionsManager(
404403
_wrap_impression_listener(cfg['impressionListener'], sdk_metadata),
405-
imp_strategy)
404+
StrategyDebugMode())
406405

407406
recorder = PipelinedRecorder(
408407
redis_adapter.pipeline,

splitio/engine/impressions.py

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,6 @@
22
from enum import Enum
33

44
from splitio.client.listener import ImpressionListenerException
5-
from splitio.engine.strategies.strategy_debug_mode import StrategyDebugMode
6-
from splitio.engine.strategies.strategy_optimized_mode import StrategyOptimizedMode
7-
#from splitio.engine.strategies import Observer, Counter
85

96
class ImpressionsMode(Enum):
107
"""Impressions tracking mode."""

splitio/engine/strategies/strategy_debug_mode.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,5 +25,5 @@ def process_impressions(self, impressions):
2525
:returns: Observed list of impressions
2626
:rtype: list[tuple[splitio.models.impression.Impression, dict]]
2727
"""
28-
imps = [(self._observer.test_and_set(imp), attrs) for imp, attrs in impressions] if self._observer is not None else impressions
28+
imps = [(self._observer.test_and_set(imp), attrs) for imp, attrs in impressions]
2929
return [i for i, _ in imps], imps

splitio/engine/strategies/strategy_optimized_mode.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ def process_impressions(self, impressions):
2727
:returns: Observed list of impressions
2828
:rtype: list[tuple[splitio.models.impression.Impression, dict]]
2929
"""
30-
imps = [(self._observer.test_and_set(imp), attrs) for imp, attrs in impressions] if self._observer else impressions
30+
imps = [(self._observer.test_and_set(imp), attrs) for imp, attrs in impressions]
3131
self._counter.track([imp for imp, _ in imps])
3232
this_hour = truncate_time(util.utctime_ms())
3333
return [i for i, _ in imps if i.previous_time is None or i.previous_time < this_hour], imps

0 commit comments

Comments
 (0)