DVPL-4301: Custom ReportingCommand crashes when it does not implement map operation

Fix:
+ Changed test for ReportingCommand.map override in ReportingCommand.ConfigurationSettings.fix_up
    Effect: We correctly identify when the ReportingCommand.map method is overridden and don't raise a KeyError when its not overridden.
+ Added check for ReportingCommand.map override in ReportingCommand.ConfigurationSettings.streaming_preop
    Effect: streaming_preop is only set if there's a map method override

Signed-off-by: David Noble <dnoble@splunk.com>

Author: David Noble

splunklib/searchcommands/reporting_command.py

@@ -162,10 +162,16 @@ def streaming_preop(self):
             Computed.
 
             """
+            command = type(self.command)
+
+            if command.map == ReportingCommand.map:
+                return ""
+
             command_line = str(self.command)
             command_name = type(self.command).name
             text = ' '.join([
                 command_name, '__map__', command_line[len(command_name) + 1:]])
+
             return text
 
         #endregion
@@ -196,15 +202,15 @@ def fix_up(cls, command):
             if command.reduce == ReportingCommand.reduce:
                 raise AttributeError('No ReportingCommand.reduce override')
 
+            if command.map == ReportingCommand.map:
+                cls._requires_preop = False
+                return
+
             f = vars(command)['map']   # Function backing the map method
                 # There is no way to add custom attributes to methods. See
                 # [Why does setattr fail on a method](http://goo.gl/aiOsqh)
                 # for an explanation.
 
-            if f == vars(ReportingCommand)['map']:
-                cls._requires_preop = False
-                return
-
             try:
                 settings = f._settings
             except AttributeError: