Skip to content

Commit e1eb4cb

Browse files
committed
Polishing.
1 parent b174ebb commit e1eb4cb

File tree

2 files changed

+4
-7
lines changed

2 files changed

+4
-7
lines changed

spring-data-jpa/src/main/java/org/springframework/data/jpa/repository/query/QueryParameterSetter.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -72,6 +72,7 @@ class NamedOrIndexedQueryParameterSetter implements QueryParameterSetter {
7272
this.temporalType = temporalType;
7373
}
7474

75+
// TODO: Refactor to use Spring's ErrorHandler instead of using a capturing ErrorHandling approach.
7576
@SuppressWarnings("unchecked")
7677
@Override
7778
public void setParameter(BindableQuery query, JpaParametersParameterAccessor accessor,

spring-data-jpa/src/main/java/org/springframework/data/jpa/repository/query/QueryParameterSetterFactory.java

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -262,16 +262,12 @@ public QueryParameterSetter create(ParameterBinding binding, DeclaredQuery decla
262262

263263
Assert.notNull(binding, "Binding must not be null");
264264

265-
JpaParameter parameter;
266265
if (!(binding.getOrigin() instanceof MethodInvocationArgument mia)) {
267-
return QueryParameterSetter.NOOP;
268-
}
269-
270-
if (binding.getOrigin() instanceof ParameterBinding.Synthetic) {
271266
return null;
272267
}
273268

274269
BindingIdentifier identifier = mia.identifier();
270+
JpaParameter parameter;
275271

276272
if (declaredQuery.hasNamedParameter()) {
277273
parameter = findParameterForBinding(parameters, identifier.getName());
@@ -281,11 +277,11 @@ public QueryParameterSetter create(ParameterBinding binding, DeclaredQuery decla
281277

282278
return parameter == null //
283279
? QueryParameterSetter.NOOP //
284-
: createSetter(values -> getValue(values, parameter, binding), binding, parameter);
280+
: createSetter(values -> getValue(values, parameter), binding, parameter);
285281
}
286282

287283
@Nullable
288-
protected Object getValue(JpaParametersParameterAccessor accessor, Parameter parameter, ParameterBinding binding) {
284+
protected Object getValue(JpaParametersParameterAccessor accessor, Parameter parameter) {
289285
return accessor.getValue(parameter);
290286
}
291287
}

0 commit comments

Comments
 (0)