Hacking: Caching

Author: mp911de

spring-data-jpa/src/main/java/org/springframework/data/jpa/repository/query/HibernateJpaParametersParameterAccessor.java

@@ -51,7 +51,7 @@ class HibernateJpaParametersParameterAccessor extends JpaParametersParameterAcce
 	 * @param values must not be {@literal null}.
 	 * @param em must not be {@literal null}.
 	 */
-	HibernateJpaParametersParameterAccessor(Parameters<?, ?> parameters, Object[] values, EntityManager em) {
+	HibernateJpaParametersParameterAccessor(JpaParameters parameters, Object[] values, EntityManager em) {
 
 		super(parameters, values);
 

spring-data-jpa/src/main/java/org/springframework/data/jpa/repository/query/JpaParametersParameterAccessor.java

@@ -31,14 +31,21 @@
  */
 public class JpaParametersParameterAccessor extends ParametersParameterAccessor {
 
+	private final JpaParameters parameters;
+
 	/**
 	 * Creates a new {@link ParametersParameterAccessor}.
 	 *
 	 * @param parameters must not be {@literal null}.
 	 * @param values must not be {@literal null}.
 	 */
-	public JpaParametersParameterAccessor(Parameters<?, ?> parameters, Object[] values) {
+	public JpaParametersParameterAccessor(JpaParameters parameters, Object[] values) {
 		super(parameters, values);
+		this.parameters = parameters;
+	}
+
+	public JpaParameters getParameters() {
+		return parameters;
 	}
 
 	@Nullable

spring-data-jpa/src/main/java/org/springframework/data/jpa/repository/query/JpaQueryCreator.java

@@ -34,7 +34,6 @@
 import org.springframework.data.jpa.domain.JpaSort;
 import org.springframework.data.jpa.repository.query.JpqlQueryBuilder.PathAndOrigin;
 import org.springframework.data.jpa.repository.query.ParameterBinding.PartTreeParameterBinding;
-import org.springframework.data.jpa.repository.query.ParameterMetadataProvider.ParameterMetadata;
 import org.springframework.data.jpa.repository.support.JpqlQueryTemplates;
 import org.springframework.data.mapping.PropertyPath;
 import org.springframework.data.mapping.PropertyReferenceException;
@@ -58,7 +57,7 @@
  * @author Andrey Kovalev
  * @author Greg Turnquist
  */
-class JpaQueryCreator extends AbstractQueryCreator<String, JpqlQueryBuilder.Predicate> {
+class JpaQueryCreator extends AbstractQueryCreator<String, JpqlQueryBuilder.Predicate> implements JpqlQueryCreator {
 
 	private final ReturnedType returnedType;
 	private final ParameterMetadataProvider provider;
@@ -113,6 +112,11 @@ public List<ParameterBinding> getBindings() {
 		return provider.getBindings();
 	}
 
+	@Override
+	public ParameterBinder getBinder() {
+		return ParameterBinderFactory.createBinder(provider.getParameters(), getBindings());
+	}
+
 	@Override
 	protected JpqlQueryBuilder.Predicate create(Part part, Iterator<Object> iterator) {
 		return toPredicate(part);
@@ -258,10 +262,6 @@ String render(int position) {
 		return "?" + position;
 	}
 
-	private String render(ParameterMetadata metadata) {
-		return render(metadata.getPosition());
-	}
-
 	/**
 	 * Creates a {@link Predicate} from the given {@link Part}.
 	 *
@@ -278,7 +278,6 @@ private JpqlQueryBuilder.Predicate toPredicate(Part part) {
 	 * @author Phil Webb
 	 * @author Oliver Gierke
 	 */
-	@SuppressWarnings({ "rawtypes" })
 	private class PredicateBuilder {
 
 		private final Part part;

spring-data-jpa/src/main/java/org/springframework/data/jpa/repository/query/JpqlQueryCreator.java

@@ -0,0 +1,34 @@
+/*
+ * Copyright 2024 the original author or authors.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *      https://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.springframework.data.jpa.repository.query;
+
+import java.util.List;
+
+import org.springframework.data.domain.Sort;
+
+/**
+ * @author Mark Paluch
+ */
+interface JpqlQueryCreator {
+
+	boolean useTupleQuery();
+
+	String createQuery(Sort sort);
+
+	List<ParameterBinding> getBindings();
+
+	ParameterBinder getBinder();
+}

spring-data-jpa/src/main/java/org/springframework/data/jpa/repository/query/ParameterMetadataProvider.java

@@ -62,54 +62,52 @@ class ParameterMetadataProvider {
 	private final @Nullable Iterator<Object> bindableParameterValues;
 	private final EscapeCharacter escape;
 	private final JpqlQueryTemplates templates;
+	private final JpaParameters jpaParameters;
 	private int position;
 
 	/**
 	 * Creates a new {@link ParameterMetadataProvider} from the given {@link CriteriaBuilder} and
 	 * {@link ParametersParameterAccessor}.
 	 *
-	 * @param builder must not be {@literal null}.
 	 * @param accessor must not be {@literal null}.
 	 * @param escape must not be {@literal null}.
 	 * @param templates must not be {@literal null}.
 	 */
-	public ParameterMetadataProvider(CriteriaBuilder builder, ParametersParameterAccessor accessor,
+	public ParameterMetadataProvider(JpaParametersParameterAccessor accessor,
 			EscapeCharacter escape, JpqlQueryTemplates templates) {
-		this(builder, accessor.iterator(), accessor.getParameters(), escape, templates);
+		this(accessor.iterator(), accessor.getParameters(), escape, templates);
 	}
 
 	/**
 	 * Creates a new {@link ParameterMetadataProvider} from the given {@link CriteriaBuilder} and {@link Parameters} with
 	 * support for parameter value customizations via {@link PersistenceProvider}.
 	 *
-	 * @param builder must not be {@literal null}.
 	 * @param parameters must not be {@literal null}.
 	 * @param escape must not be {@literal null}.
 	 * @param templates must not be {@literal null}.
 	 */
-	public ParameterMetadataProvider(CriteriaBuilder builder, Parameters<?, ?> parameters, EscapeCharacter escape,
+	public ParameterMetadataProvider(JpaParameters parameters, EscapeCharacter escape,
 			JpqlQueryTemplates templates) {
-		this(builder, null, parameters, escape, templates);
+		this(null, parameters, escape, templates);
 	}
 
 	/**
 	 * Creates a new {@link ParameterMetadataProvider} from the given {@link CriteriaBuilder} an {@link Iterable} of all
 	 * bindable parameter values, and {@link Parameters}.
 	 *
-	 * @param builder must not be {@literal null}.
 	 * @param bindableParameterValues may be {@literal null}.
 	 * @param parameters must not be {@literal null}.
 	 * @param escape must not be {@literal null}.
 	 * @param templates must not be {@literal null}.
 	 */
-	private ParameterMetadataProvider(CriteriaBuilder builder, @Nullable Iterator<Object> bindableParameterValues,
-			Parameters<?, ?> parameters, EscapeCharacter escape, JpqlQueryTemplates templates) {
+	private ParameterMetadataProvider(@Nullable Iterator<Object> bindableParameterValues, JpaParameters parameters,
+			EscapeCharacter escape, JpqlQueryTemplates templates) {
 
-		Assert.notNull(builder, "CriteriaBuilder must not be null");
 		Assert.notNull(parameters, "Parameters must not be null");
 		Assert.notNull(escape, "EscapeCharacter must not be null");
 		Assert.notNull(templates, "JpqlQueryTemplates must not be null");
 
+		this.jpaParameters = parameters;
 		this.parameters = parameters.getBindableParameters().iterator();
 		this.bindings = new ArrayList<>();
 		this.bindableParameterValues = bindableParameterValues;
@@ -207,6 +205,10 @@ public ParameterBinding nextSynthetic(Object value, Object source) {
 		return new ParameterBinding(BindingIdentifier.of(currentPosition), ParameterOrigin.synthetic(value, source));
 	}
 
+	public JpaParameters getParameters() {
+		return this.jpaParameters;
+	}
+
 	/**
 	 * @author Oliver Gierke
 	 * @author Thomas Darimont