Polishing.

Update newly added tests to reproduce the associated issue by serializing a non-standard public property style POJO.

Original pull request #3277
See #3271

Signed-off-by: Chris Bono <chris.bono@broadcom.com>
(cherry picked from commit 8156530)

Author: onobc

src/test/java/org/springframework/data/redis/serializer/JacksonJsonRedisSerializerTests.java

@@ -23,7 +23,6 @@
 
 import java.io.Serializable;
 import java.util.Arrays;
-import java.util.Objects;
 import java.util.UUID;
 
 import org.junit.jupiter.api.Test;
@@ -36,22 +35,12 @@
  * @author Thomas Darimont
  * @author Christoph Strobl
  * @author Mark Paluch
+ * @author Chris Bono
  */
 class JacksonJsonRedisSerializerTests {
 
 	private JacksonJsonRedisSerializer<Person> serializer = new JacksonJsonRedisSerializer<>(Person.class);
 
-	@Test // GH-3271
-	void canDeserializeSerialized() {
-
-		JacksonJsonRedisSerializer<SessionToken> redisSerializer = new JacksonJsonRedisSerializer<>(SessionToken.class);
-
-		SessionToken source = new SessionToken(UUID.randomUUID().toString());
-
-		byte[] serialized = redisSerializer.serialize(source);
-		assertThat(redisSerializer.deserialize(serialized)).isEqualTo(source);
-	}
-
 	@Test // DATAREDIS-241
 	void testJacksonJsonSerializerShouldReturnEmptyByteArrayWhenSerializingNull() {
 		assertThat(serializer.serialize(null)).isEqualTo(new byte[0]);
@@ -82,48 +71,47 @@ void shouldConsiderWriter() {
 		assertThat(serializer.serialize(person)).isEqualTo("foo".getBytes());
 	}
 
-	static class SessionToken implements Serializable {
+	@Test // GH-3271
+	void canDeserializeSerializedStandardPojo() {
 
-		private String userUuid;
+		// Where "Standard" is POJO w/ private fields w/ getters/setters
 
-		private SessionToken() {
-			// why jackson?
-		}
+		Person person = new PersonObjectFactory().instance();
+		byte[] serializedPerson = JsonMapper.shared().writeValueAsString(person).getBytes();
 
-		public SessionToken(String userUuid) {
-			this.userUuid = userUuid;
-		}
+		Person deserializedPerson = serializer.deserialize(serializedPerson);
 
-		public String getUserUuid() {
-			return userUuid;
-		}
+		// The bug was that the fields would be null upon deserialization
+		assertThat(deserializedPerson).isEqualTo(person);
+	}
 
-		public void setUserUuid(String userUuid) {
-			this.userUuid = userUuid;
-		}
+	@Test // GH-3271
+	void canDeserializeSerializedPropertyPojo() {
 
-		@Override
-		public boolean equals(Object o) {
-			if (o == this) {
-				return true;
-			}
-			if (o == null || getClass() != o.getClass()) {
-				return false;
-			}
-			SessionToken token = (SessionToken) o;
-			return Objects.equals(userUuid, token.userUuid);
-		}
+		// Where "Property" is POJO w/ public fields and no getters/setters
 
-		@Override
-		public int hashCode() {
-			return Objects.hash(userUuid);
-		}
+		JacksonJsonRedisSerializer<SessionTokenPropertyPojo> redisSerializer = new JacksonJsonRedisSerializer<>(JsonMapper.shared(), SessionTokenPropertyPojo.class);
+
+		SessionTokenPropertyPojo sessionToken = new SessionTokenPropertyPojo(UUID.randomUUID().toString());
+		byte[] serializedSessionToken = redisSerializer.serialize(sessionToken);//JsonMapper.shared().writeValueAsString(sessionToken).getBytes();
+
+		SessionTokenPropertyPojo deserializedSessionToken = redisSerializer.deserialize(serializedSessionToken);
 
-		@Override
-		public String toString() {
-			return "SessionToken{" + "userUuid='" + userUuid + '\'' + '}';
+		// The bug was that the fields would be null upon deserialization
+		assertThat(deserializedSessionToken.userUuid).isEqualTo(sessionToken.userUuid);
+	}
+
+	static class SessionTokenPropertyPojo implements Serializable {
+
+		public String userUuid;
+
+		private SessionTokenPropertyPojo() {
 		}
 
+		SessionTokenPropertyPojo(String userUuid) {
+			this();
+			this.userUuid = userUuid;
+		}
 	}
 
 }