Write unexpected input to stderr to ease debugging (#31)

* Write unexpected input to stderr to ease debugging

* draft: Added expected error output

* adjusted expectations

* Update tests.php

* Update tests.php

* Update tests.php

* Update tests.php

* Update cs2pr

* Update tests.php

* Update cs2pr

* Update cs2pr

Author: staabm

cs2pr

@@ -37,12 +37,14 @@ $root = @simplexml_load_string($xml);
 if ($root === false) {
     $errors = libxml_get_errors();
     if ($errors) {
-        fwrite(STDERR, $errors[0]->message.' on line '.$errors[0]->line.', column '.$errors[0]->column);
+        fwrite(STDERR, 'Error: '. rtrim($errors[0]->message).' on line '.$errors[0]->line.', column '.$errors[0]->column ."\n\n");
     } elseif (stripos($xml, '<?xml') !== 0) {
-        fwrite(STDERR, 'expecting xml stream starting with a xml opening tag.');
+        fwrite(STDERR, 'Error: Expecting xml stream starting with a xml opening tag.' ."\n\n");
     } else {
-        fwrite(STDERR, 'unknown error. expecting checkstyle formatted xml input.');
+        fwrite(STDERR, 'Error: Unknown error. Expecting checkstyle formatted xml input.' ."\n\n");
     }
+    fwrite(STDERR, $xml);
+    
     exit(2);
 }
 

tests/tests.php

@@ -36,10 +36,10 @@ function testXml($xmlPath, $expectedExit, $expectedOutput = null)
 }
 
 
-testXml(__DIR__.'/fail/empty.xml', 2);
-testXml(__DIR__.'/fail/invalid.xml', 2);
+testXml(__DIR__.'/fail/empty.xml', 2, "Error: Expecting xml stream starting with a xml opening tag.\n");
+testXml(__DIR__.'/fail/invalid.xml', 2, "Error: Start tag expected, '<' not found on line 1, column 1\n\n" .file_get_contents(__DIR__.'/fail/invalid.xml'));
 
-testXml(__DIR__.'/fail/multiple-suites.xml', 2);
+testXml(__DIR__.'/fail/multiple-suites.xml', 2, "Error: Extra content at the end of the document on line 8, column 1\n\n" .file_get_contents(__DIR__.'/fail/multiple-suites.xml'));
 
 testXml(__DIR__.'/errors/minimal.xml', 1, file_get_contents(__DIR__.'/errors/minimal.expect'));