Skip to content

Commit d98e60e

Browse files
Apply suggestions from code review
Co-authored-by: Lars Francke <jujutsu@lars-francke.de>
1 parent cc7ca9d commit d98e60e

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

deploy/config-spec/properties.yaml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -85,9 +85,9 @@ properties:
8585
unit: *unitClassName
8686
roles:
8787
- name: "metastore"
88-
# This property *is* required. It changed for derby in version 4.2.0
89-
# which we check in code and add in the ConfigMap builder instead of
90-
# the compute_files() method in crd.rs.
88+
# This property *is* required even though it is set to `false` here.
89+
# The required value changed in Derby in version 4.2.0.
90+
# We now set this value depending on the Hive version (and its corresponding Derby version) and add it to the ConfigMap programatically.
9191
required: false
9292
asOfVersion: "0.0.0"
9393
- property:

deploy/helm/hive-operator/configs/properties.yaml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -85,9 +85,9 @@ properties:
8585
unit: *unitClassName
8686
roles:
8787
- name: "metastore"
88-
# This property *is* required. It changed for derby in version 4.2.0
89-
# which we check in code and add in the ConfigMap builder instead of
90-
# the compute_files() method in crd.rs.
88+
# This property *is* required even though it is set to `false` here.
89+
# The required value changed in Derby in version 4.2.0.
90+
# We now set this value depending on the Hive version (and its corresponding Derby version) and add it to the ConfigMap programatically.```
9191
required: false
9292
asOfVersion: "0.0.0"
9393
- property:

0 commit comments

Comments
 (0)