Skip to content

Commit fa30fe4

Browse files
Update according to review
Co-authored-by: Malte Sander <contact@maltesander.com>
1 parent 7f34283 commit fa30fe4

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

rust/operator-binary/src/controller.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -737,7 +737,7 @@ fn build_metastore_rolegroup_config_map(
737737
/// The rolegroup [`StatefulSet`] runs the rolegroup, as configured by the administrator.
738738
///
739739
/// The [`Pod`](`stackable_operator::k8s_openapi::api::core::v1::Pod`)s are accessible through the
740-
/// corresponding [`Service`](`stackable_operator::k8s_openapi::api::core::v1::Service`) (from [`build_rolegroup_headless_service`] and [`build_rolegroup_metrics_service`]).
740+
/// corresponding [`Service`](`stackable_operator::k8s_openapi::api::core::v1::Service`) (via [`build_rolegroup_headless_service`] and metrics from [`build_rolegroup_metrics_service`]).
741741
#[allow(clippy::too_many_arguments)]
742742
fn build_metastore_rolegroup_statefulset(
743743
hive: &v1alpha1::HiveCluster,
@@ -1080,7 +1080,7 @@ fn build_metastore_rolegroup_statefulset(
10801080
..LabelSelector::default()
10811081
},
10821082
// TODO: Use method on RoleGroupRef once op-rs is released
1083-
service_name: Some(rolegroup_metrics_service_name(rolegroup_ref)),
1083+
service_name: Some(rolegroup_headless_service_name(rolegroup_ref)),
10841084
template: pod_template,
10851085
volume_claim_templates: Some(vec![pvc]),
10861086
..StatefulSetSpec::default()

tests/templates/kuttl/smoke/80-assert.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,4 +2,5 @@
22
apiVersion: kuttl.dev/v1beta1
33
kind: TestAssert
44
commands:
5+
- script: kubectl exec -n "$NAMESPACE" test-metastore-0 -- python /tmp/test_metastore.py -m hive-metastore.$NAMESPACE.svc.cluster.local
56
- script: kubectl exec -n "$NAMESPACE" test-metastore-0 -- python /tmp/test_metastore.py -m hive-metastore-default-headless.$NAMESPACE.svc.cluster.local

0 commit comments

Comments
 (0)