Use serde_yaml for entire_role

Author: sbernauer

crates/stackable-operator/src/role_utils.rs

@@ -504,55 +504,31 @@ mod tests {
             .into(),
         );
 
-        // Let's say we want to set some additional HTTP Proxy and IPv4 settings
-        // And we don't like the garbage collector for some reason...
-        let role: JavaCommonConfig = serde_yaml::from_str(
-            r#"
+        let entire_role: Role<(), GenericRoleConfig, JavaCommonConfig> =
+            serde_yaml::from_str("
+                # Let's say we want to set some additional HTTP Proxy and IPv4 settings
+                # And we don't like the garbage collector for some reason...
                 jvmArgumentOverrides:
                   remove:
                     - -XX:+UseG1GC
-                  add:
+                  add: # Add some networking arguments
                     - -Dhttps.proxyHost=proxy.my.corp
                     - -Dhttps.proxyPort=8080
                     - -Djava.net.preferIPv4Stack=true
-                "#,
-        )
-        .unwrap();
-
-        // For the roleGroup, let's say we need a different memory config.
-        // For that to work we first remove the flags generated by the operator and add our own.
-        // Also we override the proxy port to test that the roleGroup config takes precedence over the role config.
-        let role_group: JavaCommonConfig = serde_yaml::from_str(
-            r#"
-                jvmArgumentOverrides:
-                  removeRegex:
-                    - # We need more memory!
-                    - -Xmx.*
-                    - -Dhttps.proxyPort=.*
-                  add:
-                    - -Xmx40000m
-                    - -Dhttps.proxyPort=1234
-                "#,
-        )
-        .unwrap();
-
-        let entire_role: Role<(), GenericRoleConfig, JavaCommonConfig> = Role {
-            config: CommonConfiguration {
-                product_specific_common_config: role,
-                ..Default::default()
-            },
-            role_groups: HashMap::from([(
-                "default".to_owned(),
-                RoleGroup {
-                    config: CommonConfiguration {
-                        product_specific_common_config: role_group,
-                        ..Default::default()
-                    },
-                    replicas: Some(42),
-                },
-            )]),
-            ..Default::default()
-        };
+                roleGroups:
+                  default:
+                    # For the roleGroup, let's say we need a different memory config.
+                    # For that to work we first remove the flags generated by the operator and add our own.
+                    # Also we override the proxy port to test that the roleGroup config takes precedence over the role config.
+                    jvmArgumentOverrides:
+                      removeRegex:
+                        - -Xmx.*
+                        - -Dhttps.proxyPort=.*
+                      add:
+                        - -Xmx40000m
+                        - -Dhttps.proxyPort=1234
+            ")
+            .expect("Failed to parse role");
 
         let merged_jvm_argument_overrides = entire_role
             .get_merged_jvm_argument_overrides("default", &operator_generated)