Fix null reference bug in issue 11

Author: mwatson

Dlls/StackifyLib/StackifyLib.dll

@@ -18,46 +18,46 @@ public static void LoadSettings()
 	    {
 	        try
 	        {
-                CaptureErrorPostdata = Get("Stackify.CaptureErrorPostdata")
+                CaptureErrorPostdata = Get("Stackify.CaptureErrorPostdata", "")
                     .Equals("true", StringComparison.CurrentCultureIgnoreCase);
 
-                CaptureServerVariables = Get("Stackify.CaptureServerVariables")
+                CaptureServerVariables = Get("Stackify.CaptureServerVariables", "")
                     .Equals("true", StringComparison.CurrentCultureIgnoreCase);
-                CaptureSessionVariables = Get("Stackify.CaptureSessionVariables")
+                CaptureSessionVariables = Get("Stackify.CaptureSessionVariables", "")
                     .Equals("true", StringComparison.CurrentCultureIgnoreCase);
 
-                CaptureErrorHeaders = Get("Stackify.CaptureErrorHeaders")
+                CaptureErrorHeaders = Get("Stackify.CaptureErrorHeaders", "")
                     .Equals("true", StringComparison.CurrentCultureIgnoreCase);
 
-                CaptureErrorCookies = Get("Stackify.CaptureErrorCookies")
+                CaptureErrorCookies = Get("Stackify.CaptureErrorCookies", "")
                     .Equals("true", StringComparison.CurrentCultureIgnoreCase);
 
-                CaptureErrorHeadersWhitelist = Get("Stackify.CaptureErrorHeadersWhitelist");
+                CaptureErrorHeadersWhitelist = Get("Stackify.CaptureErrorHeadersWhitelist", "");
 
 	            if (!string.IsNullOrEmpty(CaptureErrorHeadersWhitelist))
 	            {
 	                ErrorHeaderGoodKeys = CaptureErrorHeadersWhitelist.Split(",".ToCharArray(), StringSplitOptions.RemoveEmptyEntries).ToList();
 	            }
 
-                CaptureErrorHeadersBlacklist = Get("Stackify.CaptureErrorHeadersBlacklist");
+                CaptureErrorHeadersBlacklist = Get("Stackify.CaptureErrorHeadersBlacklist", "");
                 if (!string.IsNullOrEmpty(CaptureErrorHeadersBlacklist))
                 {
                     ErrorHeaderBadKeys = CaptureErrorHeadersBlacklist.Split(",".ToCharArray(), StringSplitOptions.RemoveEmptyEntries).ToList();
                 }
 
-                CaptureErrorCookiesWhitelist = Get("Stackify.CaptureErrorCookiesWhitelist");
+                CaptureErrorCookiesWhitelist = Get("Stackify.CaptureErrorCookiesWhitelist", "");
                 if (!string.IsNullOrEmpty(CaptureErrorCookiesWhitelist))
                 {
                     ErrorCookiesGoodKeys = CaptureErrorCookiesWhitelist.Split(",".ToCharArray(), StringSplitOptions.RemoveEmptyEntries).ToList();
                 }
 
-                CaptureErrorCookiesBlacklist = Get("Stackify.CaptureErrorCookiesBlacklist");
+                CaptureErrorCookiesBlacklist = Get("Stackify.CaptureErrorCookiesBlacklist", "");
                 if (!string.IsNullOrEmpty(CaptureErrorCookiesBlacklist))
                 {
                     ErrorCookiesBadKeys = CaptureErrorCookiesBlacklist.Split(",".ToCharArray(), StringSplitOptions.RemoveEmptyEntries).ToList();
                 }
 
-                CaptureErrorSessionWhitelist = Get("Stackify.CaptureErrorSessionWhitelist");
+                CaptureErrorSessionWhitelist = Get("Stackify.CaptureErrorSessionWhitelist", "");
                 if (!string.IsNullOrEmpty(CaptureErrorSessionWhitelist))
                 {
                     ErrorSessionGoodKeys = CaptureErrorSessionWhitelist.Split(",".ToCharArray(), StringSplitOptions.RemoveEmptyEntries).ToList();
@@ -117,7 +117,7 @@ internal static string Get(string key, string defaultValue = null)
 				if (v == null)
 					v = defaultValue;
 			}
-			return v ?? "";
+			return v;
 		}
 	}
 }

Src/StackifyLib/Config.cs

@@ -108,7 +108,7 @@ public HttpClient(string apiKey, string apiUrl)
                     //To account for our initial release which had a URL just for the error module
 					string workaround = Config.Get("Stackify.Url");
 
-                    if (workaround != null)
+                    if (!string.IsNullOrEmpty(workaround))
                     {
                         workaround = System.Web.VirtualPathUtility.RemoveTrailingSlash(workaround);