feat(printer) make PromptForPassword scripting compatible

Author: cgoetz-inovex

internal/pkg/print/print.go

@@ -172,11 +172,20 @@ func (p *Printer) PromptForEnter(prompt string) error {
 func (p *Printer) PromptForPassword(prompt string) (string, error) {
 	p.Cmd.PrintErr(prompt)
 	defer p.Outputln("")
-	bytePassword, err := term.ReadPassword(int(syscall.Stdin))
+	if term.IsTerminal(syscall.Stdin) {
+		bytePassword, err := term.ReadPassword(syscall.Stdin)
+		if err != nil {
+			return "", fmt.Errorf("read password: %w", err)
+		}
+		return string(bytePassword), nil
+	}
+	// Fallback for non-terminal environments
+	reader := bufio.NewReader(p.Cmd.InOrStdin())
+	pw, err := reader.ReadString('\n')
 	if err != nil {
-		return "", fmt.Errorf("read password: %w", err)
+		return "", fmt.Errorf("read password from non-terminal: %w", err)
 	}
-	return string(bytePassword), nil
+	return pw[:len(pw)-1], nil // remove trailing newline
 }
 
 // Shows the content in the command's stdout using the "less" command

internal/pkg/print/print_test.go

@@ -6,6 +6,7 @@ import (
 	"fmt"
 	"io"
 	"log/slog"
+	"sync"
 	"testing"
 
 	"github.com/spf13/cobra"
@@ -936,3 +937,49 @@ func TestOutputResult(t *testing.T) {
 		})
 	}
 }
+
+func TestPromptForPassword(t *testing.T) {
+	tests := []struct {
+		description string
+		input       string
+	}{
+		{
+			description: "password",
+			input:       "mypassword\n",
+		},
+		{
+			description: "empty password",
+			input:       "\n",
+		},
+	}
+	for _, tt := range tests {
+		t.Run(tt.description, func(t *testing.T) {
+			cmd := &cobra.Command{}
+			r, w := io.Pipe()
+			defer func() {
+				r.Close()
+				w.Close()
+			}()
+			cmd.SetIn(r)
+			p := &Printer{
+				Cmd:       cmd,
+				Verbosity: ErrorLevel,
+			}
+			var pw string
+			var err error
+			var wg sync.WaitGroup
+			wg.Go(func() {
+				pw, err = p.PromptForPassword("Enter password: ")
+			})
+			w.Write([]byte(tt.input))
+			wg.Wait()
+			if err != nil {
+				t.Fatalf("unexpected error: %v", err)
+			}
+			withoutNewline := tt.input[:len(tt.input)-1]
+			if pw != withoutNewline {
+				t.Fatalf("unexpected password: got %q, want %q", pw, withoutNewline)
+			}
+		})
+	}
+}