Skip to content

Commit 83070d8

Browse files
committed
add unit test and nil pointer check
1 parent 4ddc9fb commit 83070d8

File tree

2 files changed

+11
-1
lines changed

2 files changed

+11
-1
lines changed

internal/cmd/beta/logs/instance/update/update.go

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -156,7 +156,11 @@ func outputResult(p *print.Printer, model *inputModel, projectLabel string, inst
156156
if instance == nil {
157157
return fmt.Errorf("instance is nil")
158158
}
159-
return p.OutputResult(model.OutputFormat, instance, func() error {
159+
var outputFormat string
160+
if model.GlobalFlagModel != nil {
161+
outputFormat = model.OutputFormat
162+
}
163+
return p.OutputResult(outputFormat, instance, func() error {
160164
p.Outputf("Updated instance %q for project %q.\n", utils.PtrString(instance.DisplayName), projectLabel)
161165
return nil
162166
})

internal/cmd/beta/logs/instance/update/update_test.go

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -267,6 +267,12 @@ func TestOutputResult(t *testing.T) {
267267
model: &inputModel{GlobalFlagModel: &globalflags.GlobalFlagModel{}},
268268
wantErr: false,
269269
},
270+
{
271+
description: "global flag nil",
272+
instance: &logs.LogsInstance{},
273+
model: &inputModel{GlobalFlagModel: nil},
274+
wantErr: false,
275+
},
270276
{
271277
description: "json output",
272278
instance: &logs.LogsInstance{},

0 commit comments

Comments
 (0)