extend nil check in outputResult functions

Author: GokceGK

internal/cmd/beta/logs/instance/create/create.go

@@ -155,18 +155,13 @@ func buildRequest(ctx context.Context, model *inputModel, apiClient *logs.APICli
 func outputResult(p *print.Printer, model *inputModel, projectLabel string, resp *logs.LogsInstance) error {
 	if resp == nil {
 		return fmt.Errorf("create logs instance response is empty")
+	} else if model == nil || model.GlobalFlagModel == nil {
+		return fmt.Errorf("input model is nil")
 	}
-	var outputFormat string
-	var async bool
 
-	if model.GlobalFlagModel != nil {
-		outputFormat = model.OutputFormat
-		async = model.Async
-	}
-
-	return p.OutputResult(outputFormat, resp, func() error {
+	return p.OutputResult(model.OutputFormat, resp, func() error {
 		operationState := "Created"
-		if async {
+		if model.Async {
 			operationState = "Triggered creation of"
 		}
 		p.Outputf("%s instance for project %q. Instance ID: %s\n", operationState, projectLabel, utils.PtrString(resp.Id))

internal/cmd/beta/logs/instance/create/create_test.go

@@ -211,11 +211,17 @@ func TestOutputResult(t *testing.T) {
 			instance:    nil,
 			wantErr:     true,
 		},
+		{
+			description: "model is nil",
+			instance:    &logs.LogsInstance{},
+			model:       nil,
+			wantErr:     true,
+		},
 		{
 			description: "global flag nil",
 			instance:    &logs.LogsInstance{},
 			model:       &inputModel{GlobalFlagModel: nil},
-			wantErr:     false,
+			wantErr:     true,
 		},
 		{
 			description: "default output",

internal/cmd/beta/logs/instance/update/update.go

@@ -155,12 +155,10 @@ func buildRequest(ctx context.Context, model *inputModel, apiClient *logs.APICli
 func outputResult(p *print.Printer, model *inputModel, projectLabel string, instance *logs.LogsInstance) error {
 	if instance == nil {
 		return fmt.Errorf("instance is nil")
+	} else if model == nil || model.GlobalFlagModel == nil {
+		return fmt.Errorf("input model is nil")
 	}
-	var outputFormat string
-	if model.GlobalFlagModel != nil {
-		outputFormat = model.OutputFormat
-	}
-	return p.OutputResult(outputFormat, instance, func() error {
+	return p.OutputResult(model.OutputFormat, instance, func() error {
 		p.Outputf("Updated instance %q for project %q.\n", utils.PtrString(instance.DisplayName), projectLabel)
 		return nil
 	})

internal/cmd/beta/logs/instance/update/update_test.go

@@ -267,11 +267,17 @@ func TestOutputResult(t *testing.T) {
 			model:       &inputModel{GlobalFlagModel: &globalflags.GlobalFlagModel{}},
 			wantErr:     false,
 		},
+		{
+			description: "model is nil",
+			instance:    &logs.LogsInstance{},
+			model:       nil,
+			wantErr:     true,
+		},
 		{
 			description: "global flag nil",
 			instance:    &logs.LogsInstance{},
 			model:       &inputModel{GlobalFlagModel: nil},
-			wantErr:     false,
+			wantErr:     true,
 		},
 		{
 			description: "json output",