Fix parsing locations with port numbers.

Author: Eric Wendelin

bower.json

@@ -1,14 +1,14 @@
 {
     "name": "error-stack-parser",
-    "version": "0.1.0",
+    "version": "0.1.1",
     "main": "./error-stack-parser.js",
-    "homepage": "https://github.com/stacktracejs/error-stack-parser.js",
+    "homepage": "https://github.com/stacktracejs/error-stack-parser",
     "authors": [
         "Eric Wendelin <me@eriwen.com>"
     ],
     "description": "Extract meaning from JS Errors",
     "dependencies": {
-        "stackframe": "0.1.0"
+        "stackframe": "~0.1.0"
     },
     "devDependencies": {
         "jasmine": "~1.3.1",
@@ -27,7 +27,7 @@
         "framework-agnostic",
         "error"
     ],
-    "license": "MIT",
+    "license": "Public Domain",
     "ignore": [
         "**/.*",
         "node_modules",

component.json

@@ -1,6 +1,6 @@
 {
     "name": "error-stack-parser",
-    "version": "0.1.0",
+    "version": "0.1.1",
     "main": "./error-stack-parser.js",
     "dependencies": {
         "stackframe": "0.1.0"

error-stack-parser.js

@@ -32,24 +32,41 @@
             }
         };
 
+        /**
+         * Separate line and column numbers from a URL-like string.
+         * @param urlLike String
+         * @return Array[String]
+         */
+        this.extractLocation = function extractLocation(urlLike) {
+            var locationParts = urlLike.split(':');
+            var lastNumber = locationParts.pop();
+            var possibleNumber = locationParts[locationParts.length - 1];
+            if (possibleNumber != Number(possibleNumber)) {
+                return [locationParts.join(':'), lastNumber, undefined];
+            } else {
+                var lineNumber = locationParts.pop();
+                return [locationParts.join(':'), lineNumber, lastNumber];
+            }
+        };
+
         this.parseV8OrIE = function parseV8OrIE(error) {
             return error.stack.split('\n').splice(1).map(function (line) {
                 var tokens = line.split(/\s+/).splice(2);
-                var location = tokens.pop().replace(/[\(\)\s]/g, '').split(':');
+                var locationParts = this.extractLocation(tokens.pop().replace(/[\(\)\s]/g, ''));
                 var functionName = (!tokens[0] || tokens[0] === 'Anonymous') ? undefined : tokens[0];
-                return new StackFrame(functionName, undefined, location[0] + ':' + location[1], location[2], location[3]);
-            });
+                return new StackFrame(functionName, undefined, locationParts[0], locationParts[1], locationParts[2]);
+            }.bind(this));
         };
 
         this.parseFFOrSafari = function parseFFOrSafari(error) {
             return error.stack.split('\n').filter(function (line) {
                 return !!line.match(this.firefoxSafariStackEntryRegExp);
             }.bind(this)).map(function (line) {
                 var tokens = line.split('@');
-                var location = tokens.pop().split(':');
+                var locationParts = this.extractLocation(tokens.pop());
                 var functionName = tokens.shift() || undefined;
-                return new StackFrame(functionName, undefined, location[0] + ':' + location[1], location[2], location[3]);
-            });
+                return new StackFrame(functionName, undefined, locationParts[0], locationParts[1], locationParts[2]);
+            }.bind(this));
         };
 
         this.parseOpera = function parseOpera(e) {

package.json

@@ -2,11 +2,11 @@
   "name": "error-stack-parser",
   "description": "Extract meaning from JS Errors",
   "author": "Eric Wendelin <me@eriwen.com> (http://eriwen.com)",
-  "version": "0.1.0",
+  "version": "0.1.1",
   "keywords": ["stacktrace", "error"],
   "homepage": "http://www.stacktracejs.com",
   "dependencies": {
-    "stackframe": "0.1.0"
+    "stackframe": "~0.1.0"
   },
   "repository": {
     "type": "git",

spec/captured-errors.js

@@ -159,8 +159,8 @@ CapturedExceptions.CHROME_36 = {
     message: "Default error",
     name: "Error",
     stack: "Error: Default error\n" +
-        "    at dumpExceptionError (file:///Users/eric/src/stacktracejs/stacktrace.js/test/functional/ExceptionLab.html:41:27)\n" +
-        "    at HTMLButtonElement.onclick (file:///Users/eric/src/stacktracejs/stacktrace.js/test/functional/ExceptionLab.html:107:146)"
+        "    at dumpExceptionError (http://localhost:8080/file.js:41:27)\n" +
+        "    at HTMLButtonElement.onclick (http://localhost:8080/file.js:107:146)"
 };
 
 CapturedExceptions.FIREFOX_3 = {

spec/error-stack-parser-spec.js

@@ -28,7 +28,7 @@ describe('ErrorStackParser', function () {
             expect(stackFrames[1]).toMatchStackFrame(['bar', undefined, 'http://path/to/file.js', 1, 1]);
         });
 
-        it('should parse V8 Error stacks', function () {
+        it('should parse V8 Error.stack', function () {
             var stackFrames = unit.parse(CapturedExceptions.CHROME_15);
             expect(stackFrames).toBeTruthy();
             expect(stackFrames.length).toBe(4);
@@ -38,6 +38,13 @@ describe('ErrorStackParser', function () {
             expect(stackFrames[3]).toMatchStackFrame([undefined, undefined, 'http://path/to/file.js', 24, 4]);
         });
 
+        it('should parse V8 Error.stack entries with port numbers', function () {
+            var stackFrames = unit.parse(CapturedExceptions.CHROME_36);
+            expect(stackFrames).toBeTruthy();
+            expect(stackFrames.length).toBe(2);
+            expect(stackFrames[0]).toMatchStackFrame(['dumpExceptionError', undefined, 'http://localhost:8080/file.js', 41, 27]);
+        });
+
         it('should parse IE 10 Error stacks', function () {
             var stackFrames = unit.parse(CapturedExceptions.IE_10);
             expect(stackFrames).toBeTruthy();