From b9a8f6d282d5af306a4dfe917917db8fe9b9da6b Mon Sep 17 00:00:00 2001 From: Daksha Date: Mon, 5 Jan 2026 02:07:50 +0530 Subject: [PATCH 1/2] test: address review comments for bernoulli quantile native tests --- .../bernoulli/quantile/test/test.native.js | 31 +++++++------------ 1 file changed, 11 insertions(+), 20 deletions(-) diff --git a/lib/node_modules/@stdlib/stats/base/dists/bernoulli/quantile/test/test.native.js b/lib/node_modules/@stdlib/stats/base/dists/bernoulli/quantile/test/test.native.js index 17bc7b0b785f..b3bbbbcc651b 100644 --- a/lib/node_modules/@stdlib/stats/base/dists/bernoulli/quantile/test/test.native.js +++ b/lib/node_modules/@stdlib/stats/base/dists/bernoulli/quantile/test/test.native.js @@ -24,9 +24,8 @@ var resolve = require( 'path' ).resolve; var tape = require( 'tape' ); var tryRequire = require( '@stdlib/utils/try-require' ); var isnan = require( '@stdlib/math/base/assert/is-nan' ); -var abs = require( '@stdlib/math/base/special/abs' ); var NINF = require( '@stdlib/constants/float64/ninf' ); -var EPS = require( '@stdlib/constants/float64/eps' ); + // VARIABLES // @@ -84,8 +83,6 @@ tape( 'if provided a success probability `p` outside `[0,1]`, the function retur tape( 'the function evaluates the quantile for `r` given small parameter `p`', opts, function test( t ) { var expected; - var delta; - var tol; var r; var p; var y; @@ -96,21 +93,17 @@ tape( 'the function evaluates the quantile for `r` given small parameter `p`', o p = smallP.p; for ( i = 0; i < r.length; i++ ) { y = quantile( r[i], p[i] ); - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'r: '+r[i]+', p: '+p[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 1.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. r: '+r[ i ]+'. p: '+p[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( + y, + expected[i], + 'r: '+r[i]+', p: '+p[i]+', y: '+y+', expected: '+expected[i] + ); } t.end(); }); tape( 'the function evaluates the quantile for `r` given large parameter `p`', opts, function test( t ) { var expected; - var delta; - var tol; var r; var p; var y; @@ -121,13 +114,11 @@ tape( 'the function evaluates the quantile for `r` given large parameter `p`', o p = largeP.p; for ( i = 0; i < r.length; i++ ) { y = quantile( r[i], p[i] ); - if ( y === expected[i] ) { - t.strictEqual( y, expected[i], 'r: '+r[i]+', p: '+p[i]+', y: '+y+', expected: '+expected[i] ); - } else { - delta = abs( y - expected[ i ] ); - tol = 1.0 * EPS * abs( expected[ i ] ); - t.ok( delta <= tol, 'within tolerance. r: '+r[ i ]+'. p: '+p[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' ); - } + t.strictEqual( + y, + expected[i], + 'r: '+r[i]+', p: '+p[i]+', y: '+y+', expected: '+expected[i] + ); } t.end(); }); From 58fc0b1bd01975925358297eedd762489811c151 Mon Sep 17 00:00:00 2001 From: Athan Date: Sun, 4 Jan 2026 17:16:41 -0800 Subject: [PATCH 2/2] chore: clean-up Signed-off-by: Athan --- .../dists/bernoulli/quantile/test/test.native.js | 15 +++------------ 1 file changed, 3 insertions(+), 12 deletions(-) diff --git a/lib/node_modules/@stdlib/stats/base/dists/bernoulli/quantile/test/test.native.js b/lib/node_modules/@stdlib/stats/base/dists/bernoulli/quantile/test/test.native.js index b3bbbbcc651b..b5a0d05bc1ed 100644 --- a/lib/node_modules/@stdlib/stats/base/dists/bernoulli/quantile/test/test.native.js +++ b/lib/node_modules/@stdlib/stats/base/dists/bernoulli/quantile/test/test.native.js @@ -22,10 +22,9 @@ var resolve = require( 'path' ).resolve; var tape = require( 'tape' ); -var tryRequire = require( '@stdlib/utils/try-require' ); var isnan = require( '@stdlib/math/base/assert/is-nan' ); var NINF = require( '@stdlib/constants/float64/ninf' ); - +var tryRequire = require( '@stdlib/utils/try-require' ); // VARIABLES // @@ -93,11 +92,7 @@ tape( 'the function evaluates the quantile for `r` given small parameter `p`', o p = smallP.p; for ( i = 0; i < r.length; i++ ) { y = quantile( r[i], p[i] ); - t.strictEqual( - y, - expected[i], - 'r: '+r[i]+', p: '+p[i]+', y: '+y+', expected: '+expected[i] - ); + t.strictEqual( y, expected[i], 'r: '+r[i]+', p: '+p[i]+', y: '+y+', expected: '+expected[i] ); } t.end(); }); @@ -114,11 +109,7 @@ tape( 'the function evaluates the quantile for `r` given large parameter `p`', o p = largeP.p; for ( i = 0; i < r.length; i++ ) { y = quantile( r[i], p[i] ); - t.strictEqual( - y, - expected[i], - 'r: '+r[i]+', p: '+p[i]+', y: '+y+', expected: '+expected[i] - ); + t.strictEqual( y, expected[i], 'r: '+r[i]+', p: '+p[i]+', y: '+y+', expected: '+expected[i] ); } t.end(); });