From 6161d5e7a70279f8aa2b8f680c02389a7d4ceec0 Mon Sep 17 00:00:00 2001 From: Bhargav Dabhade Date: Fri, 9 Jan 2026 19:05:16 +0000 Subject: [PATCH 1/2] bench: refactor to use dynamic memory allocation in stats/strided/dnanmeanwd --- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: missing_dependencies - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: na - task: lint_license_headers status: passed --- --- .../strided/dnanmeanwd/benchmark/c/benchmark.length.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/lib/node_modules/@stdlib/stats/strided/dnanmeanwd/benchmark/c/benchmark.length.c b/lib/node_modules/@stdlib/stats/strided/dnanmeanwd/benchmark/c/benchmark.length.c index a5683ea9ca39..5747632dacfd 100644 --- a/lib/node_modules/@stdlib/stats/strided/dnanmeanwd/benchmark/c/benchmark.length.c +++ b/lib/node_modules/@stdlib/stats/strided/dnanmeanwd/benchmark/c/benchmark.length.c @@ -96,11 +96,11 @@ static double rand_double( void ) { */ static double benchmark1( int iterations, int len ) { double elapsed; - double x[ len ]; + double *x; double v; double t; int i; - + x = (double *) malloc( len * sizeof( double ) ); for ( i = 0; i < len; i++ ) { x[ i ] = ( rand_double() * 20000.0 ) - 10000.0; } @@ -118,6 +118,7 @@ static double benchmark1( int iterations, int len ) { if ( v != v ) { printf( "should not return NaN\n" ); } + free( x ); return elapsed; } @@ -130,11 +131,11 @@ static double benchmark1( int iterations, int len ) { */ static double benchmark2( int iterations, int len ) { double elapsed; - double x[ len ]; + double *x; double v; double t; int i; - + x = (double *) malloc( len * sizeof( double ) ); for ( i = 0; i < len; i++ ) { if ( rand_double() < 0.2 ) { x[ i ] = 0.0 / 0.0; // NaN @@ -156,6 +157,7 @@ static double benchmark2( int iterations, int len ) { if ( v != v ) { printf( "should not return NaN\n" ); } + free( x ); return elapsed; } From db0069957b549905f0dd431d22b3a29d50584dd2 Mon Sep 17 00:00:00 2001 From: Athan Date: Fri, 9 Jan 2026 15:51:35 -0800 Subject: [PATCH 2/2] Apply suggestions from code review Signed-off-by: Athan --- .../stats/strided/dnanmeanwd/benchmark/c/benchmark.length.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/node_modules/@stdlib/stats/strided/dnanmeanwd/benchmark/c/benchmark.length.c b/lib/node_modules/@stdlib/stats/strided/dnanmeanwd/benchmark/c/benchmark.length.c index 5747632dacfd..2ec42ca8de5a 100644 --- a/lib/node_modules/@stdlib/stats/strided/dnanmeanwd/benchmark/c/benchmark.length.c +++ b/lib/node_modules/@stdlib/stats/strided/dnanmeanwd/benchmark/c/benchmark.length.c @@ -100,6 +100,7 @@ static double benchmark1( int iterations, int len ) { double v; double t; int i; + x = (double *) malloc( len * sizeof( double ) ); for ( i = 0; i < len; i++ ) { x[ i ] = ( rand_double() * 20000.0 ) - 10000.0; @@ -135,6 +136,7 @@ static double benchmark2( int iterations, int len ) { double v; double t; int i; + x = (double *) malloc( len * sizeof( double ) ); for ( i = 0; i < len; i++ ) { if ( rand_double() < 0.2 ) {