Skip to content

Commit 411b7e8

Browse files
Add bcrypt as a dependency
CI was failing because the generated user model was being placed in the test directory as expected. I think the problem was that the test command was testing that file before it could be deleted. Since the user model contains a call to `has_secure_password` which requires bcrypt, CI was raising an error. I think the larger the install command is, the slower the test suite will run, which will result in intermittent failures. I was not running into this locally because my machine simply has more resources.
1 parent 0636402 commit 411b7e8

File tree

3 files changed

+4
-1
lines changed

3 files changed

+4
-1
lines changed

.github/workflows/ci.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,4 +22,4 @@ jobs:
2222
- name: Run Standard
2323
run: bundle exec standardrb
2424
- name: Run tests
25-
run: bundle exec rails test test/rails_mvp_authentication_test.rb
25+
run: bundle exec rails test

Gemfile

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@ end
1111

1212
group :development, :test do
1313
gem "standard", "~> 1.7"
14+
gem "bcrypt", "~> 3.1.7"
1415
end
1516

1617
# Start debugger with binding.b -- Read more: https://github.com/ruby/debug

Gemfile.lock

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -74,6 +74,7 @@ GEM
7474
minitest (>= 5.1)
7575
tzinfo (~> 2.0)
7676
ast (2.4.2)
77+
bcrypt (3.1.16)
7778
builder (3.2.4)
7879
concurrent-ruby (1.1.9)
7980
crass (1.0.6)
@@ -189,6 +190,7 @@ PLATFORMS
189190
arm64-darwin-21
190191

191192
DEPENDENCIES
193+
bcrypt (~> 3.1.7)
192194
rails_mvp_authentication!
193195
sprockets-rails (~> 3.4, >= 3.4.2)
194196
sqlite3

0 commit comments

Comments
 (0)