Skip to content

Commit 6da46a2

Browse files
Fix broken user table migration
The orignal command was creating a "users_tables" table instead of a "users" table. Issues ------ - Closes #29
1 parent 59b7567 commit 6da46a2

File tree

2 files changed

+5
-4
lines changed

2 files changed

+5
-4
lines changed

lib/generators/rails_mvp_authentication/install_generator.rb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -175,7 +175,7 @@ def create_user_model
175175
end
176176

177177
def create_users_table
178-
generate "migration", "create_users_table email:string:index confirmed_at:datetime password_digest:string unconfirmed_email:string"
178+
generate "migration", "create_users email:string:index confirmed_at:datetime password_digest:string unconfirmed_email:string"
179179
end
180180

181181
def create_user_views
@@ -232,7 +232,7 @@ def modify_users_table
232232
migration = Dir.glob(Rails.root.join("db/migrate/*")).max_by { |f| File.mtime(f) }
233233
gsub_file migration, /t.string :email/, "t.string :email, null: false"
234234
gsub_file migration, /t.string :password_digest/, "t.string :password_digest, null: false"
235-
gsub_file migration, /add_index :users_tables, :email/, "add_index :users_tables, :email, unique: true"
235+
gsub_file migration, /add_index :users, :email/, "add_index :users, :email, unique: true"
236236
end
237237

238238
def path_to(path)

test/lib/generators/rails_mvp_authentication/install_generator_test.rb

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,9 @@ class RailsMvpAuthentication::InstallGeneratorTest < Rails::Generators::TestCase
1111
test "creates migration for users table" do
1212
run_generator
1313

14-
assert_migration "db/migrate/create_users_table.rb" do |migration|
15-
assert_match(/add_index :users_tables, :email, unique: true/, migration)
14+
assert_migration "db/migrate/create_users.rb" do |migration|
15+
assert_match(/create_table :users do |t|/, migration)
16+
assert_match(/add_index :users, :email, unique: true/, migration)
1617
assert_match(/t.string :email, null: false/, migration)
1718
assert_match(/t.string :password_digest, null: false/, migration)
1819
end

0 commit comments

Comments
 (0)