Only perform the strcpy if writeTo and readFrom are different from one another, otherwise valgrind is raising an error (and would be right about doing so).

Valgrind error message: Source and destination overlap in strcpy
Further information: https://www.valgrind.org/docs/manual/mc-manual.html#mc-manual.overlap

Author: aentinger

api/String.cpp

@@ -656,7 +656,8 @@ void String::replace(const String& find, const String& replace)
 			readFrom = foundAt + find.len;
 			len += diff;
 		}
-		strcpy(writeTo, readFrom);
+		if (writeTo != readFrom)
+			strcpy(writeTo, readFrom);
 	} else {
 		unsigned int size = len; // compute size needed for result
 		while ((foundAt = strstr(readFrom, find.buffer)) != NULL) {