test(unit): fix return code

Author: cameronr

run_tests.sh

@@ -1,8 +1,8 @@
 #!/bin/bash
 # run_tests.sh - Test runner with clean failure summary
 
-SCRIPT_DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd )"
-cd "$SCRIPT_DIR"
+SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
+cd "$SCRIPT_DIR" || exit 1
 
 # Colors
 GREEN='\033[0;32m'
@@ -31,23 +31,23 @@ print_usage() {
 
 while [[ $# -gt 0 ]]; do
     case $1 in
-        -f|--filter)
-            FILTER="$2"
-            shift 2
-            ;;
-        -t|--type)
-            TEST_TYPE="$2"
-            shift 2
-            ;;
-        -h|--help)
-            print_usage
-            exit 0
-            ;;
-        *)
-            echo "Unknown option: $1"
-            print_usage
-            exit 1
-            ;;
+    -f | --filter)
+        FILTER="$2"
+        shift 2
+        ;;
+    -t | --type)
+        TEST_TYPE="$2"
+        shift 2
+        ;;
+    -h | --help)
+        print_usage
+        exit 0
+        ;;
+    *)
+        echo "Unknown option: $1"
+        print_usage
+        exit 1
+        ;;
     esac
 done
 
@@ -110,14 +110,14 @@ if [ "$TEST_TYPE" != "all" ] && [ "$TEST_TYPE" != "minimal" ] && [ "$TEST_TYPE"
         specific_output=$(nvim --headless -u tests/minimal/init.lua -c "lua require('plenary.test_harness').test_directory('./$TEST_TYPE', {minimal_init = './tests/minimal/init.lua'$FILTER_OPTION})" 2>&1)
         specific_status=$?
         clean_output "$specific_output"
-        
+
         if [ $specific_status -eq 0 ]; then
             echo -e "${GREEN}✓ Specific test passed${NC}"
         else
             echo -e "${RED}✗ Specific test failed${NC}"
         fi
         echo "------------------------------------------------"
-        
+
         # Use specific test output for failure analysis
         unit_output="$specific_output"
         unit_status=$specific_status
@@ -131,22 +131,22 @@ fi
 all_output="$minimal_output
 $unit_output"
 
-if [ $minimal_status -ne 0 ] || [ $unit_status -ne 0 ] || echo "$all_output" | grep -q "\[31mFail"; then
+if [ $minimal_status -ne 0 ] || [ $unit_status -ne 0 ] || echo "$all_output" | grep -q "\[31mFail.*||"; then
     echo -e "\n${RED}======== TEST FAILURES SUMMARY ========${NC}"
-    
+
     # Extract and format failures
     failures_file=$(mktemp)
-    echo "$all_output" | grep -B 0 -A 6 "\[31mFail.*||" > "$failures_file"
+    echo "$all_output" | grep -B 0 -A 6 "\[31mFail.*||" >"$failures_file"
     failure_count=$(grep -c "\[31mFail.*||" "$failures_file")
-    
+
     echo -e "${RED}Found $failure_count failing test(s):${NC}\n"
-    
+
     # Process the output line by line
     test_name=""
     while IFS= read -r line; do
         # Remove ANSI color codes
         clean_line=$(echo "$line" | sed -E 's/\x1B\[[0-9;]*[mK]//g')
-        
+
         if [[ "$clean_line" == *"Fail"*"||"* ]]; then
             # Extract test name
             test_name=$(echo "$clean_line" | sed -E 's/.*Fail.*\|\|\s*(.*)/\1/')
@@ -161,8 +161,8 @@ if [ $minimal_status -ne 0 ] || [ $unit_status -ne 0 ] || echo "$all_output" | g
             # Stack trace details
             echo -e "    $clean_line"
         fi
-    done < "$failures_file"
-    
+    done <"$failures_file"
+
     rm -f "$failures_file"
     exit 1
 else