Support passing distribution version names for Ubuntu/Debian, add unit tests #251
+216
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- In other words, being able to pass "--distribution-version noble" instead of only "--distribution-version 24.0.4".
- Only compiled if Testing module is available. - 100% code coverage of LinuxDistribution.
MaxDesiatov
changed the title
Contributor
|
@swift-ci test |
Contributor
Author
|
Oops, got a typo in there! Also forgot the header on the new file. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #235. With this change you can now pass the code name of the version to the generator:
swift run swift-sdk-generator make-linux-sdk --distribution-name ubuntu --distribution-version nobleswift run swift-sdk-generator make-linux-sdk --distribution-name Debian --distribution-version trixieAlso, as a part of attempting to improve test coverage of the generator, I've added
LinuxDistributionTestsbuilt on Swift Testing to complete coverage ofLinuxDistribution. It is only compiled/run on Swift 6.0 and later, so it should always be invoked on the current CIs. Once swift-tools-version is set to 6.0 the#if canImport(Testing)wrapper can be removed!