Clean Tests

Author: Behemyth

tests/integration/plugins/conan/test_provider.py

@@ -1,5 +1,6 @@
 """Integration tests for the provider"""
 
+from pathlib import Path
 from typing import Any
 
 import pytest
@@ -8,6 +9,23 @@
 from cppython.test.pytest.contracts import ProviderIntegrationTestContract
 
 
+@pytest.fixture(autouse=True)
+def clean_conan_cache(tmp_path: Path, monkeypatch: pytest.MonkeyPatch):
+    """Sets CONAN_HOME to a temporary directory for each test.
+
+    This ensures all tests run with a clean Conan cache.
+
+    Args:
+        tmp_path: Pytest temporary directory fixture
+        monkeypatch: Pytest monkeypatch fixture for environment variable manipulation
+    """
+    conan_home = tmp_path / 'conan_home'
+    conan_home.mkdir()
+
+    # Set CONAN_HOME to the temporary directory
+    monkeypatch.setenv('CONAN_HOME', str(conan_home))
+
+
 class TestConanProvider(ProviderIntegrationTestContract[ConanProvider]):
     """The tests for the conan provider"""
 

tests/unit/plugins/conan/test_install.py

@@ -136,210 +136,7 @@ def mock_resolve(requirement: Requirement) -> ConanDependency:
         # Verify Conan API was attempted
         mock_conan_api_constructor.assert_called_once()
 
-    def test_install_with_profile_exception_fallback(
-        self,
-        plugin: ConanProvider,
-        conan_temp_conanfile: Path,
-        conan_mock_dependencies: list[Requirement],
-        conan_setup_mocks: dict[str, Mock],
-        conan_mock_api: Mock,
-    ) -> None:
-        """Test install method when profile operations throw exceptions
-
-        Args:
-            plugin: The plugin instance
-            conan_temp_conanfile: Path to temporary conanfile.py
-            conan_mock_dependencies: List of mock dependencies
-            conan_setup_mocks: Dictionary containing all mocks
-            conan_mock_api: Mock ConanAPI instance
-        """
-        # Configure the API mock to throw exception on first profile call
-        conan_mock_api.profiles.get_default_host.side_effect = Exception('Profile not found')
-
-        # Setup dependencies
-        plugin.core_data.cppython_data.dependencies = conan_mock_dependencies
-
-        # Execute - should not throw an exception despite profile operations failing
-        plugin.install()
-
-        # Verify that despite the exceptions, the fallback was used
-        conan_setup_mocks['conan_api_constructor'].assert_called_once()
-        conan_mock_api.profiles.get_default_host.assert_called_once()
-        # Note: get_default_build is not called because get_default_host throws exception first
-
-        # Verify fallback profile creation was called (should be called twice for detect)
-        assert conan_mock_api.profiles.detect.call_count >= EXPECTED_PROFILE_CALLS
-
-        # Verify the rest of the process continued
-        conan_mock_api.graph.load_graph_consumer.assert_called_once()
-        conan_mock_api.install.install_binaries.assert_called_once()
-        conan_mock_api.install.install_consumer.assert_called_once()
-
-    def test_publish_with_profile_exception_fallback(
-        self,
-        plugin: ConanProvider,
-        conan_temp_conanfile: Path,
-        conan_mock_api_publish: Mock,
-        mocker: MockerFixture,
-    ) -> None:
-        """Test publish method when profile operations throw exceptions
-
-        Args:
-            plugin: The plugin instance
-            conan_temp_conanfile: Path to temporary conanfile.py
-            conan_mock_api_publish: Mock ConanAPI instance configured for publish
-            mocker: Pytest mocker fixture
-        """
-        # Set plugin to local mode to avoid remote upload complications
-        plugin.data = plugin.data.__class__(
-            remotes=[],
-        )
-
-        # Configure the API mock to throw exception on first profile call
-        conan_mock_api_publish.profiles.get_default_host.side_effect = Exception('Profile configuration error')
-
-        # Mock ConanAPI constructor to return our configured mock
-        mock_conan_api_constructor = mocker.patch(
-            'cppython.plugins.conan.plugin.ConanAPI', return_value=conan_mock_api_publish
-        )
-
-        # Execute - should not throw an exception despite profile operations failing
-        plugin.publish()
-
-        # Verify that despite the exceptions, the fallback was used
-        mock_conan_api_constructor.assert_called_once()
-        conan_mock_api_publish.profiles.get_default_host.assert_called_once()
-        # Note: get_default_build is not called because get_default_host throws exception first
-
-        # Verify fallback profile creation was called (should be called twice for detect)
-        assert conan_mock_api_publish.profiles.detect.call_count >= EXPECTED_PROFILE_CALLS
-
-        # Verify the rest of the process continued
-        conan_mock_api_publish.export.export.assert_called_once()
-        conan_mock_api_publish.graph.load_graph_consumer.assert_called_once()
-        conan_mock_api_publish.install.install_binaries.assert_called_once()
-
-    def test_install_with_second_profile_exception_fallback(
-        self,
-        plugin: ConanProvider,
-        conan_temp_conanfile: Path,
-        conan_mock_dependencies: list[Requirement],
-        conan_setup_mocks: dict[str, Mock],
-        conan_mock_api: Mock,
-    ) -> None:
-        """Test install method when the second profile operation throws exception
-
-        Args:
-            plugin: The plugin instance
-            conan_temp_conanfile: Path to temporary conanfile.py
-            conan_mock_dependencies: List of mock dependencies
-            conan_setup_mocks: Dictionary containing all mocks
-            conan_mock_api: Mock ConanAPI instance
-        """
-        # Configure the API mock: first call succeeds, second one fails
-        conan_mock_api.profiles.get_default_host.return_value = '/path/to/host'
-        conan_mock_api.profiles.get_default_build.side_effect = Exception('Build profile not found')
-
-        # Setup dependencies
-        plugin.core_data.cppython_data.dependencies = conan_mock_dependencies
-
-        # Execute - should not throw an exception despite profile operations failing
-        plugin.install()
-
-        # Verify that despite the exceptions, the fallback was used
-        conan_setup_mocks['conan_api_constructor'].assert_called_once()
-        conan_mock_api.profiles.get_default_host.assert_called_once()
-        conan_mock_api.profiles.get_default_build.assert_called_once()
-
-        # Verify fallback profile creation was called (should be called twice for detect)
-        assert conan_mock_api.profiles.detect.call_count >= EXPECTED_PROFILE_CALLS
-
-        # Verify the rest of the process continued
-        conan_mock_api.graph.load_graph_consumer.assert_called_once()
-        conan_mock_api.install.install_binaries.assert_called_once()
-        conan_mock_api.install.install_consumer.assert_called_once()
-
-    def test_install_with_get_profile_returning_none_fallback(
-        self,
-        plugin: ConanProvider,
-        conan_temp_conanfile: Path,
-        conan_mock_dependencies: list[Requirement],
-        conan_setup_mocks: dict[str, Mock],
-        conan_mock_api: Mock,
-    ) -> None:
-        """Test install method when get_profile returns None (profile file corrupted/invalid)
-
-        Args:
-            plugin: The plugin instance
-            conan_temp_conanfile: Path to temporary conanfile.py
-            conan_mock_dependencies: List of mock dependencies
-            conan_setup_mocks: Dictionary containing all mocks
-            conan_mock_api: Mock ConanAPI instance
-        """
-        # Configure profiles to exist but get_profile returns None (corrupted/invalid profile)
-        conan_mock_api.profiles.get_default_host.return_value = '/path/to/host/profile'
-        conan_mock_api.profiles.get_default_build.return_value = '/path/to/build/profile'
-        conan_mock_api.profiles.get_profile.return_value = None  # Profile file exists but is corrupted
-
-        # Setup dependencies
-        plugin.core_data.cppython_data.dependencies = conan_mock_dependencies
-
-        # Execute - should not throw an exception despite get_profile returning None
-        plugin.install()
-
-        # Verify that despite get_profile returning None, the fallback was used
-        conan_setup_mocks['conan_api_constructor'].assert_called_once()
-        conan_mock_api.profiles.get_default_host.assert_called_once()
-        conan_mock_api.profiles.get_default_build.assert_called_once()
-
-        # Should call get_profile twice (once for host, once for build)
-        assert conan_mock_api.profiles.get_profile.call_count == EXPECTED_GET_PROFILE_CALLS
-
-        # Verify fallback profile creation was called (should be called twice for detect)
-        assert conan_mock_api.profiles.detect.call_count >= EXPECTED_PROFILE_CALLS
-
-        # Verify the rest of the process continued
-        conan_mock_api.graph.load_graph_consumer.assert_called_once()
-        conan_mock_api.install.install_binaries.assert_called_once()
-        conan_mock_api.install.install_consumer.assert_called_once()
-
-    def test_install_with_detect_returning_none_graceful_handling(
-        self,
-        plugin: ConanProvider,
-        conan_temp_conanfile: Path,
-        conan_mock_dependencies: list[Requirement],
-        conan_setup_mocks: dict[str, Mock],
-        conan_mock_api: Mock,
-    ) -> None:
-        """Test install method when detect() returns None (graceful handling)
-
-        Args:
-            plugin: The plugin instance
-            conan_temp_conanfile: Path to temporary conanfile.py
-            conan_mock_dependencies: List of mock dependencies
-            conan_setup_mocks: Dictionary containing all mocks
-            conan_mock_api: Mock ConanAPI instance
-        """
-        # Configure profiles to not exist and detect to return None
-        conan_mock_api.profiles.get_default_host.return_value = None
-        conan_mock_api.profiles.get_default_build.return_value = None
-        conan_mock_api.profiles.detect.return_value = None  # This should be handled gracefully
-
-        # Setup dependencies
-        plugin.core_data.cppython_data.dependencies = conan_mock_dependencies
-
-        # Execute - should succeed gracefully by letting Conan handle None profiles
-        plugin.install()
-
-        # Verify that detect was called (fallback was attempted)
-        conan_mock_api.profiles.detect.assert_called()
-
-        # Verify the rest of the process continued (profiles were omitted from API call)
-        conan_mock_api.graph.load_graph_consumer.assert_called_once()
-        conan_mock_api.install.install_binaries.assert_called_once()
-        conan_mock_api.install.install_consumer.assert_called_once()
-
-    def test_install_with_profile_exception_fallback_to_detect_works(
+    def test_install_with_profile_exception(
         self,
         plugin: ConanProvider,
         conan_temp_conanfile: Path,

tests/unit/plugins/conan/test_publish.py

@@ -1,6 +1,5 @@
 """Unit tests for the conan plugin publish functionality"""
 
-from pathlib import Path
 from typing import Any
 from unittest.mock import MagicMock, Mock
 
@@ -286,50 +285,3 @@ def test_publish_list_pattern_creation(
 
         # Verify ListPattern was created with correct reference pattern
         mock_list_pattern.assert_called_once_with(f'{ref.name}/*', package_id='*', only_recipe=False)
-
-    def test_publish_with_get_profile_returning_none_fallback(
-        self,
-        plugin: ConanProvider,
-        conan_temp_conanfile: Path,
-        conan_mock_api_publish: Mock,
-        mocker: MockerFixture,
-    ) -> None:
-        """Test publish method when get_profile returns None (profile file corrupted/invalid)
-
-        Args:
-            plugin: The plugin instance
-            conan_temp_conanfile: Path to temporary conanfile.py
-            conan_mock_api_publish: Mock ConanAPI instance configured for publish
-            mocker: Pytest mocker fixture
-        """
-        # Set plugin to local mode to avoid remote upload complications
-        plugin.data = plugin.data.__class__(
-            remotes=[],
-        )
-
-        # Configure profiles to exist but get_profile returns None (corrupted/invalid profile)
-        conan_mock_api_publish.profiles.get_default_host.return_value = '/path/to/host/profile'
-        conan_mock_api_publish.profiles.get_default_build.return_value = '/path/to/build/profile'
-        conan_mock_api_publish.profiles.get_profile.return_value = None  # Profile file exists but is corrupted
-
-        # Mock ConanAPI constructor to return our configured mock
-        mock_conan_api_constructor = mocker.patch(
-            'cppython.plugins.conan.plugin.ConanAPI', return_value=conan_mock_api_publish
-        )
-
-        # Execute - should not throw an exception despite get_profile returning None
-        plugin.publish()
-
-        # Verify that despite get_profile returning None, the fallback was used
-        mock_conan_api_constructor.assert_called_once()
-        conan_mock_api_publish.profiles.get_default_host.assert_called_once()
-        conan_mock_api_publish.profiles.get_default_build.assert_called_once()
-
-        # Should call get_profile twice (once for host, once for build)
-        assert conan_mock_api_publish.profiles.get_profile.call_count == EXPECTED_PROFILE_CALLS
-
-        # Verify fallback profile creation was called (should be called twice for detect)
-        assert conan_mock_api_publish.profiles.detect.call_count >= EXPECTED_PROFILE_CALLS
-
-        # Verify the rest of the process continued
-        conan_mock_api_publish.export.export.assert_called_once()