Commit a2177d8
authored
This PR fixes an issue where the `data-open` state on the
`ComboboxInput` wasn't always up to date. You can see this behavior if
you use the `immediate` prop, focus into the `ComboboxInput`, then press
`Escape` to close the combobox. The `data-open` state would still be
present.
This was just a silly internal bug where the `useMemo` dependencies were
not correctly set up. Simplified the internal `useMemo` hook and made
sure all the dependencies are available.
Fixes: #3718
1 parent 987bfa3 commit a2177d8
File tree
2 files changed
+6
-9
lines changed- packages/@headlessui-react
- src/components/combobox
2 files changed
+6
-9
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
18 | 18 | | |
19 | 19 | | |
20 | 20 | | |
| 21 | + | |
21 | 22 | | |
22 | 23 | | |
23 | 24 | | |
| |||
Lines changed: 5 additions & 9 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
903 | 903 | | |
904 | 904 | | |
905 | 905 | | |
| 906 | + | |
| 907 | + | |
| 908 | + | |
906 | 909 | | |
907 | | - | |
908 | | - | |
909 | | - | |
910 | | - | |
911 | | - | |
912 | | - | |
913 | | - | |
914 | | - | |
915 | | - | |
| 910 | + | |
| 911 | + | |
916 | 912 | | |
917 | 913 | | |
918 | 914 | | |
| |||
0 commit comments