Skip to content

Commit 8539fce

Browse files
committed
Renamed create to create_instance
in ObjectTransformer
1 parent 096e4ee commit 8539fce

File tree

3 files changed

+9
-6
lines changed

3 files changed

+9
-6
lines changed

javaobj/v2/api.py

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -38,10 +38,13 @@ class ObjectTransformer:
3838
Representation of an object transformer
3939
"""
4040

41-
def create(self, classdesc, parser=None):
42-
# type: (JavaClassDesc, Optional[JavaStreamParser]) -> Optional[JavaInstance]
41+
def create_instance(self, classdesc):
42+
# type: (JavaClassDesc) -> Optional[JavaInstance]
4343
"""
44-
Transforms a parsed Java object into a Python object
44+
Transforms a parsed Java object into a Python object.
45+
46+
The result must be a JavaInstance bean, or None if the transformer
47+
doesn't support this kind of instance.
4548
4649
:param classdesc: The description of a Java class
4750
:return: The Python form of the object, or the original JavaObject

javaobj/v2/core.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -445,7 +445,7 @@ def _create_instance(self, class_desc):
445445
"""
446446
# Try to create the transformed object
447447
for transformer in self.__transformers:
448-
instance = transformer.create(class_desc)
448+
instance = transformer.create_instance(class_desc)
449449
if instance is not None:
450450
return instance
451451

javaobj/v2/transformers.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -431,8 +431,8 @@ def __init__(self):
431431
for class_name in transformer_class.HANDLED_CLASSES:
432432
self._type_mapper[class_name] = transformer_class
433433

434-
def create(self, classdesc):
435-
# type: (JavaClassDesc) -> JavaInstance
434+
def create_instance(self, classdesc):
435+
# type: (JavaClassDesc) -> Optional[JavaInstance]
436436
"""
437437
Transforms a parsed Java object into a Python object
438438

0 commit comments

Comments
 (0)