Fix errorprone and compiler warnings (#496)

* Fix errorprone and compiler warnings

Signed-off-by: Tihomir Surdilovic <tihomir@temporal.io>

* update - fail build on any issues

Signed-off-by: Tihomir Surdilovic <tihomir@temporal.io>

---------

Signed-off-by: Tihomir Surdilovic <tihomir@temporal.io>

Author: tsurdilo

README.md

@@ -142,4 +142,5 @@ More info on each sample:
 - [**Hello**](/springboot/src/main/java/io/temporal/samples/springboot/hello): Invoke simple "Hello" workflow from a GET endpoint
 - [**SDK Metrics**](/springboot/src/main/java/io/temporal/samples/springboot/metrics): Learn how to set up SDK Metrics
 - [**Synchronous Update**](/springboot/src/main/java/io/temporal/samples/springboot/update): Learn how to use Synchronous Update feature with this purchase sample
-    
+- [**Kafka Request / Reply**](/springboot/src/main/java/io/temporal/samples/springboot/kafka): Sample showing possible integration with event streaming platforms such as Kafka
+       

build.gradle

@@ -15,6 +15,11 @@ subprojects {
         sourceCompatibility = JavaVersion.VERSION_1_8
         targetCompatibility = JavaVersion.VERSION_1_8
     }
+
+    compileJava {
+        options.compilerArgs << "-Werror"
+    }
+
     ext {
         otelVersion = '1.27.0'
         otelVersionAlpha = "${otelVersion}-alpha"

core/build.gradle

@@ -46,11 +46,7 @@ dependencies {
 
     dependencies {
         errorproneJavac('com.google.errorprone:javac:9+181-r4173-1')
-        if (JavaVersion.current().isJava11Compatible()) {
-            errorprone('com.google.errorprone:error_prone_core:2.20.0')
-        } else {
-            errorprone('com.google.errorprone:error_prone_core:2.20.0')
-        }
+        errorprone('com.google.errorprone:error_prone_core:2.20.0')
     }
 }
 

core/src/main/java/io/temporal/samples/hello/HelloActivity.java

@@ -150,7 +150,7 @@ public static void main(String[] args) {
      */
     worker.registerWorkflowImplementationTypes(GreetingWorkflowImpl.class);
 
-    /**
+    /*
      * Register our Activity Types with the Worker. Since Activities are stateless and thread-safe,
      * the Activity Type is a shared instance.
      */

core/src/main/java/io/temporal/samples/hello/HelloActivityExclusiveChoice.java

@@ -107,7 +107,7 @@ public interface OrderFruitsActivities {
   // Define the workflow implementation. It implements our orderFruit workflow method
   public static class PurchaseFruitsWorkflowImpl implements PurchaseFruitsWorkflow {
 
-    /**
+    /*
      * Define the OrderActivities stub. Activity stubs implements activity interfaces and proxy
      * calls to it to Temporal activity invocations. Since Temporal activities are reentrant, a
      * single activity stub can be used for multiple activity invocations.
@@ -208,7 +208,7 @@ public static void main(String[] args) {
      */
     worker.registerWorkflowImplementationTypes(PurchaseFruitsWorkflowImpl.class);
 
-    /**
+    /*
      * Register our Activity Types with the Worker. Since Activities are stateless and thread-safe,
      * the Activity Type is a shared instance.
      */

core/src/main/java/io/temporal/samples/hello/HelloActivityRetry.java

@@ -185,7 +185,7 @@ public static void main(String[] args) {
      */
     worker.registerWorkflowImplementationTypes(GreetingWorkflowImpl.class);
 
-    /**
+    /*
      * Register our Activity Types with the Worker. Since Activities are stateless and thread-safe,
      * the Activity Type is a shared instance.
      */

core/src/main/java/io/temporal/samples/hello/HelloAsync.java

@@ -83,7 +83,7 @@ public interface GreetingActivities {
   // Define the workflow implementation which implements our getGreeting workflow method.
   public static class GreetingWorkflowImpl implements GreetingWorkflow {
 
-    /**
+    /*
      * Define the GreetingActivities stub. Activity stubs are proxies for activity invocations that
      * are executed outside of the workflow thread on the activity worker, that can be on a
      * different host. Temporal is going to dispatch the activity results back to the workflow and
@@ -155,7 +155,7 @@ public static void main(String[] args) {
      */
     worker.registerWorkflowImplementationTypes(GreetingWorkflowImpl.class);
 
-    /**
+    /*
      * Register our Activity Types with the Worker. Since Activities are stateless and thread-safe,
      * the Activity Type is a shared instance.
      */

core/src/main/java/io/temporal/samples/hello/HelloAsyncActivityCompletion.java

@@ -84,7 +84,7 @@ public interface GreetingActivities {
   // Define the workflow implementation which implements the getGreeting workflow method.
   public static class GreetingWorkflowImpl implements GreetingWorkflow {
 
-    /**
+    /*
      * Define the GreetingActivities stub. Activity stubs are proxies for activity invocations that
      * are executed outside of the workflow thread on the activity worker, that can be on a
      * different host. Temporal is going to dispatch the activity results back to the workflow and
@@ -112,7 +112,7 @@ public String getGreeting(String name) {
    */
   static class GreetingActivitiesImpl implements GreetingActivities {
 
-    /**
+    /*
      * ActivityCompletionClient is used to asynchronously complete activities. In this example we
      * will use this client alongside with {@link
      * io.temporal.activity.ActivityExecutionContext#doNotCompleteOnReturn()} which means our
@@ -134,7 +134,7 @@ public String composeGreeting(String greeting, String name) {
       // Set a correlation token that can be used to complete the activity asynchronously
       byte[] taskToken = context.getTaskToken();
 
-      /**
+      /*
        * For the example we will use a {@link java.util.concurrent.ForkJoinPool} to execute our
        * activity. In real-life applications this could be any service. The composeGreetingAsync
        * method is the one that will actually complete workflow action execution.
@@ -165,37 +165,37 @@ public static void main(String[] args) throws ExecutionException, InterruptedExc
     // Get a Workflow service stub.
     WorkflowServiceStubs service = WorkflowServiceStubs.newLocalServiceStubs();
 
-    /**
+    /*
      * Get a Workflow service client which can be used to start, Signal, and Query Workflow
      * Executions.
      */
     WorkflowClient client = WorkflowClient.newInstance(service);
 
-    /**
+    /*
      * Define the workflow factory. It is used to create workflow workers for a specific task queue.
      */
     WorkerFactory factory = WorkerFactory.newInstance(client);
 
-    /**
+    /*
      * Define the workflow worker. Workflow workers listen to a defined task queue and process
      * workflows and activities.
      */
     Worker worker = factory.newWorker(TASK_QUEUE);
 
-    /**
+    /*
      * Register our Workflow Types with the Worker. Workflow Types must be known to the Worker at
      * runtime in order for it to poll for Workflow Tasks.
      */
     worker.registerWorkflowImplementationTypes(GreetingWorkflowImpl.class);
 
-    /**
+    /*
      * Register our Activity Types with the Worker. Since Activities are stateless and thread-safe,
      * the Activity Type is a shared instance.
      */
     ActivityCompletionClient completionClient = client.newActivityCompletionClient();
     worker.registerActivitiesImplementations(new GreetingActivitiesImpl(completionClient));
 
-    /**
+    /*
      * Start all the Workers registered for a specific Task Queue. The Workers then start polling
      * for Workflow Tasks and Activity Tasks.
      */
@@ -210,7 +210,7 @@ public static void main(String[] args) throws ExecutionException, InterruptedExc
                 .setTaskQueue(TASK_QUEUE)
                 .build());
 
-    /**
+    /*
      * Here we use {@link io.temporal.client.WorkflowClient} to execute our workflow asynchronously.
      * It gives us back a {@link java.util.concurrent.CompletableFuture}. We can then call its get
      * method to block and wait until a result is available.

core/src/main/java/io/temporal/samples/hello/HelloAsyncLambda.java

@@ -83,7 +83,7 @@ public interface GreetingActivities {
   // Define the workflow implementation which implements our getGreeting workflow method.
   public static class GreetingWorkflowImpl implements GreetingWorkflow {
 
-    /**
+    /*
      * Define the GreetingActivities stub. Activity stubs are proxies for activity invocations that
      * are executed outside of the workflow thread on the activity worker, that can be on a
      * different host. Temporal is going to dispatch the activity results back to the workflow and
@@ -173,7 +173,7 @@ public static void main(String[] args) {
      */
     worker.registerWorkflowImplementationTypes(GreetingWorkflowImpl.class);
 
-    /**
+    /*
      * Register our Activity Types with the Worker. Since Activities are stateless and thread-safe,
      * the Activity Type is a shared instance.
      */

core/src/main/java/io/temporal/samples/hello/HelloDetachedCancellationScope.java

@@ -153,36 +153,36 @@ public static void main(String[] args) throws InterruptedException {
     // Get a Workflow service stub.
     WorkflowServiceStubs service = WorkflowServiceStubs.newLocalServiceStubs();
 
-    /**
+    /*
      * Get a Workflow service client which can be used to start, Signal, and Query Workflow
      * Executions.
      */
     WorkflowClient client = WorkflowClient.newInstance(service);
 
-    /**
+    /*
      * Define the workflow factory. It is used to create workflow workers for a specific task queue.
      */
     WorkerFactory factory = WorkerFactory.newInstance(client);
 
-    /**
+    /*
      * Define the workflow worker. Workflow workers listen to a defined task queue and process
      * workflows and activities.
      */
     Worker worker = factory.newWorker(TASK_QUEUE);
 
-    /**
+    /*
      * Register our Workflow Types with the Worker. Workflow Types must be known to the Worker at
      * runtime.
      */
     worker.registerWorkflowImplementationTypes(GreetingWorkflowImpl.class);
 
-    /**
+    /*
      * Register our Activity Types with the Worker. Since Activities are stateless and thread-safe,
      * the Activity Type is a shared instance.
      */
     worker.registerActivitiesImplementations(new GreetingActivitiesImpl());
 
-    /**
+    /*
      * Start all the Workers that are in this process. The Workers will then start polling for
      * Workflow Tasks and Activity Tasks.
      */