refactor: force consistent type imports

Types must be imported:
- as separate type imports
- in the last position of import groups

Author: Belco90

eslint.config.mjs

@@ -37,6 +37,7 @@ const config = defineConfig(
 			'max-lines-per-function': 'off',
 
 			// TypeScript
+			'@typescript-eslint/consistent-type-imports': 'error',
 			'@typescript-eslint/explicit-function-return-type': 'off',
 			'@typescript-eslint/no-unused-vars': [
 				'warn',
@@ -50,7 +51,14 @@ const config = defineConfig(
 			'import-x/order': [
 				'warn',
 				{
-					groups: ['builtin', 'external', 'parent', 'sibling', 'index'],
+					groups: [
+						'builtin',
+						'external',
+						'internal',
+						['parent', 'sibling', 'index'],
+						'object',
+						'type',
+					],
 					'newlines-between': 'always',
 
 					alphabetize: {

lib/configs/index.ts

@@ -1,12 +1,9 @@
 import { join } from 'path';
 
-import type { TSESLint } from '@typescript-eslint/utils';
+import { importDefault, SUPPORTED_TESTING_FRAMEWORKS } from '../utils';
 
-import {
-	importDefault,
-	SUPPORTED_TESTING_FRAMEWORKS,
-	SupportedTestingFramework,
-} from '../utils';
+import type { SupportedTestingFramework } from '../utils';
+import type { TSESLint } from '@typescript-eslint/utils';
 
 const configsDir = __dirname;
 

lib/create-testing-library-rule/detect-testing-library-utils.ts

@@ -1,4 +1,4 @@
-import { ASTUtils, TSESLint, TSESTree } from '@typescript-eslint/utils';
+import { ASTUtils } from '@typescript-eslint/utils';
 
 import {
 	findClosestVariableDeclaratorNode,
@@ -9,7 +9,6 @@ import {
 	getPropertyIdentifierNode,
 	getReferenceNode,
 	hasImportMatch,
-	ImportModuleNode,
 	isCallExpression,
 	isImportDeclaration,
 	isImportDefaultSpecifier,
@@ -31,6 +30,9 @@ import {
 	isTestingLibraryModule,
 } from '../utils/is-testing-library-module';
 
+import type { ImportModuleNode } from '../node-utils';
+import type { TSESLint, TSESTree } from '@typescript-eslint/utils';
+
 const SETTING_OPTION_OFF = 'off';
 
 export type TestingLibrarySettings = {

lib/create-testing-library-rule/index.ts

@@ -1,14 +1,14 @@
 import { ESLintUtils } from '@typescript-eslint/utils';
 
-import {
-	getDocsUrl,
+import { getDocsUrl } from '../utils';
+import { detectTestingLibraryUtils } from './detect-testing-library-utils';
+
+import type {
 	TestingLibraryPluginDocs,
 	TestingLibraryPluginRuleModule,
 } from '../utils';
-
-import {
+import type {
 	DetectionOptions,
-	detectTestingLibraryUtils,
 	EnhancedRuleCreate,
 } from './detect-testing-library-utils';
 

lib/index.ts

@@ -1,8 +1,8 @@
-import type { TSESLint } from '@typescript-eslint/utils';
-
 import configs from './configs';
 import rules from './rules';
-import { SupportedTestingFramework } from './utils';
+
+import type { SupportedTestingFramework } from './utils';
+import type { TSESLint } from '@typescript-eslint/utils';
 
 // we can't natively import package.json as tsc will copy it into dist/
 const {

lib/node-utils/index.ts

@@ -1,13 +1,7 @@
-import { FunctionScope, ScopeType } from '@typescript-eslint/scope-manager';
-import {
-	AST_NODE_TYPES,
-	ASTUtils,
-	TSESLint,
-	TSESTree,
-} from '@typescript-eslint/utils';
+import { ScopeType } from '@typescript-eslint/scope-manager';
+import { AST_NODE_TYPES, ASTUtils } from '@typescript-eslint/utils';
 
 import { getDeclaredVariables, getScope } from '../utils';
-
 import {
 	isArrayExpression,
 	isArrowFunctionExpression,
@@ -28,6 +22,9 @@ import {
 	isVariableDeclaration,
 } from './is-node-of-type';
 
+import type { FunctionScope } from '@typescript-eslint/scope-manager';
+import type { TSESLint, TSESTree } from '@typescript-eslint/utils';
+
 export * from './is-node-of-type';
 
 const ValidLeftHandSideExpressions = [

lib/rules/await-async-events.ts

@@ -1,4 +1,4 @@
-import { ASTUtils, TSESLint, TSESTree } from '@typescript-eslint/utils';
+import { ASTUtils } from '@typescript-eslint/utils';
 
 import { createTestingLibraryRule } from '../create-testing-library-rule';
 import {
@@ -12,6 +12,8 @@ import {
 } from '../node-utils';
 import { EVENTS_SIMULATORS } from '../utils';
 
+import type { TSESLint, TSESTree } from '@typescript-eslint/utils';
+
 export const RULE_NAME = 'await-async-events';
 export type MessageIds = 'awaitAsyncEvent' | 'awaitAsyncEventWrapper';
 const FIRE_EVENT_NAME = 'fireEvent';

lib/rules/await-async-queries.ts

@@ -1,4 +1,4 @@
-import { ASTUtils, TSESTree } from '@typescript-eslint/utils';
+import { ASTUtils } from '@typescript-eslint/utils';
 
 import { createTestingLibraryRule } from '../create-testing-library-rule';
 import {
@@ -10,6 +10,8 @@ import {
 	isPromiseHandled,
 } from '../node-utils';
 
+import type { TSESTree } from '@typescript-eslint/utils';
+
 export const RULE_NAME = 'await-async-queries';
 export type MessageIds = 'asyncQueryWrapper' | 'awaitAsyncQuery';
 type Options = [];

lib/rules/await-async-utils.ts

@@ -1,4 +1,4 @@
-import { TSESTree, ASTUtils } from '@typescript-eslint/utils';
+import { ASTUtils } from '@typescript-eslint/utils';
 
 import { createTestingLibraryRule } from '../create-testing-library-rule';
 import {
@@ -13,6 +13,8 @@ import {
 	isProperty,
 } from '../node-utils';
 
+import type { TSESTree } from '@typescript-eslint/utils';
+
 export const RULE_NAME = 'await-async-utils';
 export type MessageIds = 'asyncUtilWrapper' | 'awaitAsyncUtil';
 type Options = [];

lib/rules/index.ts

@@ -1,7 +1,9 @@
 import { readdirSync } from 'fs';
 import { join, parse } from 'path';
 
-import { importDefault, TestingLibraryPluginRuleModule } from '../utils';
+import { importDefault } from '../utils';
+
+import type { TestingLibraryPluginRuleModule } from '../utils';
 
 const rulesDir = __dirname;
 const excludedFiles = ['index'];