Define pcap_open() etc. even without remote capture.

They also support local capture, and we build them even without remote
capture, as their absence may complicate code build on macOS 14 with
Xcode 15, as that platform supports "weakly linked symbols":

https://developer.apple.com/library/archive/documentation/MacOSX/Conceptual/BPFrameworks/Concepts/WeakLinking.html

which are symbols in dynamically-linked shared libraries, declared in
such a fashion that if a program linked against a newer software
development kit (SDK), and using a symbol present in the OS version for
which that SDK is provided, is run on an older OS version that lacks
that symbol, that symbol's value is a NULL pointer.  This allows those
programs to test for the presence of that symbol by checking whether
it's non-null and, if it is, using the symbol, otherwise not using it.

See Wireshark issue 19349:

https://gitlab.com/wireshark/wireshark/-/issues/19349

and this note in that issue:

https://gitlab.com/wireshark/wireshark/-/issues/19349#note_1573375784

for a possible example of such a complication (Apple may have added a
stub pcap_open() to handle this, but that breaks code that expects
pcap_open() to work if present).

Add pcap_open() support in the opentest test program, with the -o flag.

Author: guyharris

CMakeLists.txt

@@ -2693,7 +2693,7 @@ if(ENABLE_REMOTE)
     check_struct_has_member("struct msghdr" msg_flags "ftmacros.h;sys/socket.h" HAVE_STRUCT_MSGHDR_MSG_FLAGS)
     cmake_pop_check_state()
     set(PROJECT_SOURCE_LIST_C ${PROJECT_SOURCE_LIST_C}
-        pcap-new.c pcap-rpcap.c rpcap-protocol.c sockutils.c sslutils.c)
+        pcap-rpcap.c rpcap-protocol.c sockutils.c sslutils.c)
 endif(ENABLE_REMOTE)
 
 ###################################################################

Makefile.in

@@ -321,7 +321,6 @@ EXTRA_DIST = \
 	pcap-libdlpi.c \
 	pcap-linux.c \
 	pcap-namedb.h \
-	pcap-new.c \
 	pcap-netfilter-linux.c \
 	pcap-netfilter-linux.h \
 	pcap-netmap.c \

configure.ac

@@ -1945,7 +1945,7 @@ return 0;
 
 	AC_DEFINE(ENABLE_REMOTE,,
 	    [Define to 1 if remote packet capture is to be supported])
-	REMOTE_C_SRC="$REMOTE_C_SRC pcap-new.c pcap-rpcap.c rpcap-protocol.c sockutils.c sslutils.c"
+	REMOTE_C_SRC="$REMOTE_C_SRC pcap-rpcap.c rpcap-protocol.c sockutils.c sslutils.c"
 	BUILD_RPCAPD=build-rpcapd
 	INSTALL_RPCAPD=install-rpcapd
 	;;