Fixing PHPStan

Author: moufmouf

DependencyInjection/GraphqlControllersCompilerPass.php

@@ -33,6 +33,7 @@
 use TheCodingMachine\GraphQL\Controllers\Mappers\StaticTypeMapper;
 use TheCodingMachine\GraphQL\Controllers\NamingStrategy;
 use TheCodingMachine\GraphQL\Controllers\TypeGenerator;
+use TheCodingMachine\GraphQL\Controllers\Types\MutableObjectType;
 use TheCodingMachine\GraphQL\Controllers\Types\ResolvableInputObjectType;
 
 /**
@@ -250,20 +251,20 @@ public static function createQueryProvider($controller, FieldsBuilderFactory $fi
     }
 
     /**
-     * @param object $typeClass
+     * @param string $typeClass
      */
-    public static function createObjectType($typeClass, TypeGenerator $typeGenerator, RecursiveTypeMapperInterface $recursiveTypeMapper): ObjectType
+    /*public static function createObjectType(string $typeClass, TypeGenerator $typeGenerator, RecursiveTypeMapperInterface $recursiveTypeMapper): MutableObjectType
     {
         return $typeGenerator->mapAnnotatedObject($typeClass, $recursiveTypeMapper);
-    }
+    }*/
 
     /**
      * @param object $factory
      */
-    public static function createInputObjectType($factory, string $methodName, InputTypeGenerator $inputTypeGenerator, RecursiveTypeMapperInterface $recursiveTypeMapper): InputObjectType
+    /*public static function createInputObjectType($factory, string $methodName, InputTypeGenerator $inputTypeGenerator, RecursiveTypeMapperInterface $recursiveTypeMapper): InputObjectType
     {
         return $inputTypeGenerator->mapFactoryMethod($factory, $methodName, $recursiveTypeMapper);
-    }
+    }*/
 
     /**
      * Returns a cached Doctrine annotation reader.

Mappers/ContainerFetcherTypeMapper.php

@@ -4,6 +4,7 @@
 namespace TheCodingMachine\Graphql\Controllers\Bundle\Mappers;
 
 use GraphQL\Type\Definition\InputObjectType;
+use GraphQL\Type\Definition\NamedType;
 use GraphQL\Type\Definition\ObjectType;
 use GraphQL\Type\Definition\Type;
 use GraphQL\Type\Definition\InputType;
@@ -80,7 +81,7 @@ public function canMapClassToType(string $className): bool
     public function mapClassToType(string $className, ?OutputType $subType, RecursiveTypeMapperInterface $recursiveTypeMapper): MutableObjectType
     {
         $key = $className;
-        if ($subType !== null) {
+        if ($subType instanceof NamedType && $subType !== null) {
             $key .= '____'.$subType->name;
         }
         if (isset($this->types[$key])) {

phpstan.neon

@@ -2,5 +2,6 @@ parameters:
     ignoreErrors:
         - "#Call to an undefined method Symfony\\\\Component\\\\Config\\\\Definition\\\\Builder\\\\NodeDefinition::children\\(\\)#"
         - "/Parameter #2 $haystack of function in_array expects array, array<string>|string given./"
+        - "#Access to an undefined property GraphQL\\\\Type\\\\Definition\\\\NamedType&GraphQL\\\\Type\\\\Definition\\\\OutputType::\\$name.#"
 #includes:
 #    - vendor/thecodingmachine/phpstan-strict-rules/phpstan-strict-rules.neon