Fixing bug with magic parameters and expression with parenthesis

Author: moufmouf

src/SQLParser/Node/Expression.php

@@ -182,6 +182,10 @@ public function toSql(array $parameters = array(), Connection $dbConnection = nu
     {
         $sql = NodeFactory::toSql($this->subTree, $dbConnection, $parameters, ' ', false, $indent, $conditionsMode);
 
+        if ($sql === null) {
+            return null;
+        }
+
         if ($this->alias) {
             $sql .= ' AS '.$this->alias;
         }
@@ -192,6 +196,7 @@ public function toSql(array $parameters = array(), Connection $dbConnection = nu
             $sql = '('.$sql.')';
         }
 
+
         return $sql;
     }
 

tests/Mouf/Database/MagicQueryTest.php

@@ -123,6 +123,9 @@ public function testStandardSelect()
 
         $sql = 'SELECT * FROM users GROUP BY id, login';
         $this->assertEquals('SELECT * FROM users GROUP BY id, login', self::simplifySql($magicQuery->build($sql)));
+
+        $sql = 'SELECT * FROM users WHERE (login LIKE :login)';
+        $this->assertEquals('SELECT * FROM users', self::simplifySql($magicQuery->build($sql)));
     }
 
     /**