Fixing PHPStan

Author: moufmouf

phpstan.neon

@@ -1,5 +1,5 @@
 parameters:
-    level: 3
+    level: 2
     ignoreErrors:
         - "#Mouf\\\\MoufManager#"
         - "#Mouf\\\\MoufInstanceDescriptor#"

src/Mouf/Database/MagicQuery/Twig/SqlTwigEnvironmentFactory.php

@@ -2,6 +2,8 @@
 
 namespace Mouf\Database\MagicQuery\Twig;
 
+use Twig_Extension_Core;
+
 /**
  * Class in charge of creating the Twig environment.
  */
@@ -28,7 +30,10 @@ public static function getTwigEnvironment()
 
         // Default escaper will throw an exception. This is because we want to use SQL parameters instead of Twig.
         // This has a number of advantages, especially in terms of caching.
-        $twig->getExtension('Twig_Extension_Core')->setEscaper('sql', function () {
+
+        /** @var Twig_Extension_Core $twigExtensionCore */
+        $twigExtensionCore = $twig->getExtension('Twig_Extension_Core');
+        $twigExtensionCore->setEscaper('sql', function () {
             throw new ForbiddenTwigParameterInSqlException('You cannot use Twig expressions (like "{{ id }}"). Instead, you should use SQL parameters (like ":id"). Twig integration is limited to Twig statements (like "{% for .... %}"');
         });
 

src/Mouf/Database/QueryWriter/QueryResult.php

@@ -2,6 +2,7 @@
 
 namespace Mouf\Database\QueryWriter;
 
+use function method_exists;
 use Mouf\Database\QueryWriter\Utils\DbHelper;
 use Mouf\Utils\Value\ValueUtils;
 use SQLParser\Query\Select;
@@ -114,7 +115,9 @@ public function sort($key, $direction = SortableInterface::ASC)
             if (method_exists($columnObj, 'setAlias')) {
                 $columnObj->setAlias(null);
             }
-            $columnObj->setDirection($direction);
+            if (method_exists($columnObj, 'setDirection')) {
+                $columnObj->setDirection($direction);
+            }
         } else {
             $columnObj = new ColRef();
             $columnObj->setColumn($key);

src/SQLParser/Node/Expression.php

@@ -199,7 +199,7 @@ public function toInstanceDescriptor(MoufManager $moufManager)
      * @param number     $indent
      * @param int        $conditionsMode
      *
-     * @return string
+     * @return string|null
      */
     public function toSql(array $parameters = array(), Connection $dbConnection = null, $indent = 0, $conditionsMode = self::CONDITION_APPLY, bool $extrapolateParameters = true)
     {