Reaching PHPStan level 6

Author: moufmouf

phpstan.neon

@@ -1,6 +1,7 @@
 parameters:
-    level: 5
+    level: 6
     inferPrivatePropertyTypeFromConstructor: true
     ignoreErrors:
         - "#Mouf\\\\MoufManager#"
-        - "#Mouf\\\\MoufInstanceDescriptor#"
+        - "#Mouf\\\\MoufInstanceDescriptor#"
+        - '#Method Mouf\\Database\\QueryWriter\\Utils\\FindParametersService::findParameters\(\) should return array<string> but returns array<int, int\|string>#'

src/SQLParser/Node/AbstractManyInstancesOperator.php

@@ -64,7 +64,7 @@ public function toInstanceDescriptor(MoufManager $moufManager)
      * @param bool $extrapolateParameters
      * @return string
      */
-    public function toSql(array $parameters, AbstractPlatform $platform, $indent = 0, $conditionsMode = self::CONDITION_APPLY, bool $extrapolateParameters = true): ?string
+    public function toSql(array $parameters, AbstractPlatform $platform, int $indent = 0, $conditionsMode = self::CONDITION_APPLY, bool $extrapolateParameters = true): ?string
     {
         $sqlOperands = array();
         foreach ($this->operands as $operand) {

src/SQLParser/Node/AbstractTwoOperandsOperator.php

@@ -97,7 +97,7 @@ public function toInstanceDescriptor(MoufManager $moufManager)
      * @param bool $extrapolateParameters
      * @return string
      */
-    public function toSql(array $parameters, AbstractPlatform $platform, $indent = 0, $conditionsMode = self::CONDITION_APPLY, bool $extrapolateParameters = true): ?string
+    public function toSql(array $parameters, AbstractPlatform $platform, int $indent = 0, $conditionsMode = self::CONDITION_APPLY, bool $extrapolateParameters = true): ?string
     {
         if ($conditionsMode == self::CONDITION_GUESS) {
             $bypass = false;

src/SQLParser/Node/AggregateFunction.php

@@ -152,7 +152,7 @@ public function toInstanceDescriptor(MoufManager $moufManager)
      * @param bool $extrapolateParameters
      * @return string
      */
-    public function toSql(array $parameters, AbstractPlatform $platform, $indent = 0, $conditionsMode = self::CONDITION_APPLY, bool $extrapolateParameters = true): ?string
+    public function toSql(array $parameters, AbstractPlatform $platform, int $indent = 0, $conditionsMode = self::CONDITION_APPLY, bool $extrapolateParameters = true): ?string
     {
         $subTreeSql = NodeFactory::toSql($this->subTree, $platform, $parameters, ', ', false, $indent, $conditionsMode, $extrapolateParameters);
         if ($subTreeSql !== null) {

src/SQLParser/Node/Between.php

@@ -37,43 +37,43 @@ public function setLeftOperand($leftOperand)
     }
 
     /**
-     * @var string|NodeInterface|NodeInterface[]
+     * @var NodeInterface
      */
     private $minValueOperand;
 
     /**
-     * @var string|NodeInterface|NodeInterface[]
+     * @var NodeInterface
      */
     private $maxValueOperand;
 
     /**
-     * @return NodeInterface|NodeInterface[]|string
+     * @return NodeInterface
      */
     public function getMinValueOperand()
     {
         return $this->minValueOperand;
     }
 
     /**
-     * @param NodeInterface|NodeInterface[]|string $minValueOperand
+     * @param NodeInterface $minValueOperand
      */
-    public function setMinValueOperand($minValueOperand)
+    public function setMinValueOperand(NodeInterface $minValueOperand)
     {
         $this->minValueOperand = $minValueOperand;
     }
 
     /**
-     * @return NodeInterface|NodeInterface[]|string
+     * @return NodeInterface
      */
     public function getMaxValueOperand()
     {
         return $this->maxValueOperand;
     }
 
     /**
-     * @param NodeInterface|NodeInterface[]|string $maxValueOperand
+     * @param NodeInterface $maxValueOperand
      */
-    public function setMaxValueOperand($maxValueOperand)
+    public function setMaxValueOperand(NodeInterface $maxValueOperand)
     {
         $this->maxValueOperand = $maxValueOperand;
     }
@@ -154,7 +154,7 @@ public function toInstanceDescriptor(MoufManager $moufManager)
      * @param bool $extrapolateParameters
      * @return string
      */
-    public function toSql(array $parameters, AbstractPlatform $platform, $indent = 0, $conditionsMode = self::CONDITION_APPLY, bool $extrapolateParameters = true): ?string
+    public function toSql(array $parameters, AbstractPlatform $platform, int $indent = 0, $conditionsMode = self::CONDITION_APPLY, bool $extrapolateParameters = true): ?string
     {
         $minBypass = false;
         $maxBypass = false;

src/SQLParser/Node/CaseOperation.php

@@ -60,7 +60,7 @@ public function toInstanceDescriptor(MoufManager $moufManager)
      * @param bool $extrapolateParameters
      * @return string
      */
-    public function toSql(array $parameters, AbstractPlatform $platform, $indent = 0, $conditionsMode = self::CONDITION_APPLY, bool $extrapolateParameters = true): ?string
+    public function toSql(array $parameters, AbstractPlatform $platform, int $indent = 0, $conditionsMode = self::CONDITION_APPLY, bool $extrapolateParameters = true): ?string
     {
         $sql = 'CASE '.NodeFactory::toSql($this->operation, $platform, $parameters, ' ', false, $indent, $conditionsMode).' END';
 

src/SQLParser/Node/ColRef.php

@@ -192,7 +192,7 @@ public function toInstanceDescriptor(MoufManager $moufManager)
      * @param bool $extrapolateParameters
      * @return string
      */
-    public function toSql(array $parameters, AbstractPlatform $platform, $indent = 0, $conditionsMode = self::CONDITION_APPLY, bool $extrapolateParameters = true): ?string
+    public function toSql(array $parameters, AbstractPlatform $platform, int $indent = 0, $conditionsMode = self::CONDITION_APPLY, bool $extrapolateParameters = true): ?string
     {
         $sql = '';
         if ($this->database) {

src/SQLParser/Node/ConstNode.php

@@ -106,7 +106,7 @@ public function toInstanceDescriptor(MoufManager $moufManager)
      * @param bool $extrapolateParameters
      * @return string
      */
-    public function toSql(array $parameters, AbstractPlatform $platform, $indent = 0, $conditionsMode = self::CONDITION_APPLY, bool $extrapolateParameters = true): ?string
+    public function toSql(array $parameters, AbstractPlatform $platform, int $indent = 0, $conditionsMode = self::CONDITION_APPLY, bool $extrapolateParameters = true): ?string
     {
         if ($this->value === null) {
             return 'NULL';

src/SQLParser/Node/Expression.php

@@ -203,7 +203,7 @@ public function toInstanceDescriptor(MoufManager $moufManager)
      * @param bool $extrapolateParameters
      * @return string|null
      */
-    public function toSql(array $parameters, AbstractPlatform $platform, $indent = 0, $conditionsMode = self::CONDITION_APPLY, bool $extrapolateParameters = true): ?string
+    public function toSql(array $parameters, AbstractPlatform $platform, int $indent = 0, $conditionsMode = self::CONDITION_APPLY, bool $extrapolateParameters = true): ?string
     {
         if (empty($this->subTree)) {
             return $this->getBaseExpression();

src/SQLParser/Node/LimitNode.php

@@ -83,15 +83,15 @@ public function toInstanceDescriptor(MoufManager $moufManager)
      *
      * @param array $parameters
      * @param AbstractPlatform $platform
-     * @param int|number $indent
+     * @param int $indent
      * @param int $conditionsMode
      *
      * @param bool $extrapolateParameters
      * @return string
      *
      * @throws \Exception
      */
-    public function toSql(array $parameters, AbstractPlatform $platform, $indent = 0, $conditionsMode = self::CONDITION_APPLY, bool $extrapolateParameters = true): ?string
+    public function toSql(array $parameters, AbstractPlatform $platform, int $indent = 0, $conditionsMode = self::CONDITION_APPLY, bool $extrapolateParameters = true): ?string
     {
         if ($this->value === null) {
             throw new \Exception('A limit parameter must be an integer');