Skip to content

Commit 5a090a6

Browse files
lyakhlgirdwood
authored andcommitted
schedule: remove schedule_task_complete()
schedule_task_complete() is never used, remove it. Signed-off-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
1 parent 0a835bd commit 5a090a6

File tree

6 files changed

+0
-57
lines changed

6 files changed

+0
-57
lines changed

src/include/sof/schedule/schedule.h

Lines changed: 0 additions & 33 deletions
Original file line numberDiff line numberDiff line change
@@ -99,17 +99,6 @@ struct scheduler_ops {
9999
*/
100100
int (*schedule_task_running)(void *data, struct task *task);
101101

102-
/**
103-
* Sets task into completed state along with executing additional
104-
* scheduler specific operations.
105-
* @param data Private data of selected scheduler.
106-
* @param task Task to be set into completed state.
107-
* @return 0 if succeeded, error code otherwise.
108-
*
109-
* This operation is optional.
110-
*/
111-
int (*schedule_task_complete)(void *data, struct task *task);
112-
113102
/**
114103
* Reschedules already scheduled task with new start time.
115104
* @param data Private data of selected scheduler.
@@ -221,28 +210,6 @@ static inline int schedule_task_running(struct task *task)
221210
return -ENODEV;
222211
}
223212

224-
/** See scheduler_ops::schedule_task_complete */
225-
static inline int schedule_task_complete(struct task *task)
226-
{
227-
struct schedulers *schedulers = *arch_schedulers_get();
228-
struct schedule_data *sch;
229-
struct list_item *slist;
230-
231-
list_for_item(slist, &schedulers->list) {
232-
sch = container_of(slist, struct schedule_data, list);
233-
if (task->type == sch->type) {
234-
/* optional operation */
235-
if (!sch->ops->schedule_task_complete)
236-
return 0;
237-
238-
return sch->ops->schedule_task_complete(sch->data,
239-
task);
240-
}
241-
}
242-
243-
return -ENODEV;
244-
}
245-
246213
/** See scheduler_ops::schedule_task */
247214
static inline int schedule_task(struct task *task, uint64_t start,
248215
uint64_t period)

src/platform/library/schedule/edf_schedule.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,6 @@ static int schedule_edf_task_free(void *data, struct task *task)
8282
static struct scheduler_ops schedule_edf_ops = {
8383
.schedule_task = schedule_edf_task,
8484
.schedule_task_running = NULL,
85-
.schedule_task_complete = NULL,
8685
.reschedule_task = NULL,
8786
.schedule_task_cancel = schedule_edf_task_cancel,
8887
.schedule_task_free = schedule_edf_task_free,

src/platform/library/schedule/ll_schedule.c

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -153,19 +153,6 @@ static void *ll_thread(void *data)
153153
return NULL;
154154
}
155155

156-
static int schedule_ll_task_complete(void *data, struct task *task)
157-
{
158-
struct ll_vcore *vc = data;
159-
160-
/* task is complete so remove it from list */
161-
pthread_mutex_lock(&vc->list_mutex);
162-
list_item_del(&task->list);
163-
task->state = SOF_TASK_STATE_COMPLETED;
164-
pthread_mutex_unlock(&vc->list_mutex);
165-
166-
return 0;
167-
}
168-
169156
/* schedule new LL task */
170157
static int schedule_ll_task(void *data, struct task *task, uint64_t start,
171158
uint64_t period)
@@ -285,7 +272,6 @@ static int schedule_ll_task_free(void *data, struct task *task)
285272
static struct scheduler_ops schedule_ll_ops = {
286273
.schedule_task = schedule_ll_task,
287274
.schedule_task_running = NULL,
288-
.schedule_task_complete = schedule_ll_task_complete,
289275
.reschedule_task = NULL,
290276
.schedule_task_cancel = schedule_ll_task_cancel,
291277
.schedule_task_free = schedule_ll_task_free,

src/schedule/edf_schedule.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -329,7 +329,6 @@ static void schedule_edf(struct edf_schedule_data *edf_sch)
329329
static const struct scheduler_ops schedule_edf_ops = {
330330
.schedule_task = schedule_edf_task,
331331
.schedule_task_running = schedule_edf_task_running,
332-
.schedule_task_complete = schedule_edf_task_complete,
333332
.reschedule_task = NULL,
334333
.schedule_task_cancel = schedule_edf_task_cancel,
335334
.schedule_task_free = schedule_edf_task_free,

src/schedule/ll_schedule.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -802,5 +802,4 @@ static const struct scheduler_ops schedule_ll_ops = {
802802
.scheduler_free = scheduler_free_ll,
803803
.scheduler_restore = NULL,
804804
.schedule_task_running = NULL,
805-
.schedule_task_complete = NULL,
806805
};

zephyr/edf_schedule.c

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -75,12 +75,6 @@ static int schedule_edf_task_cancel(void *data, struct task *task)
7575
return 0;
7676
}
7777

78-
static int schedule_edf_task_complete(void *data, struct task *task)
79-
{
80-
task_complete(task);
81-
return 0;
82-
}
83-
8478
static int schedule_edf_task_running(void *data, struct task *task)
8579
{
8680
task->state = SOF_TASK_STATE_RUNNING;
@@ -99,7 +93,6 @@ static int schedule_edf_task_free(void *data, struct task *task)
9993
static struct scheduler_ops schedule_edf_ops = {
10094
.schedule_task = schedule_edf_task,
10195
.schedule_task_running = schedule_edf_task_running,
102-
.schedule_task_complete = schedule_edf_task_complete,
10396
.schedule_task_cancel = schedule_edf_task_cancel,
10497
.schedule_task_free = schedule_edf_task_free,
10598
};

0 commit comments

Comments
 (0)