Skip to content

Commit eed7cd2

Browse files
serhiy-katsyuba-intellgirdwood
authored andcommitted
intel: Fix for Zephyr pre-wakeup latency calc bug
Fix for Zephyr bug (?) introduced by this commit: zephyrproject-rtos/zephyr#88145 Before that commit, the conversion of wakeup exit latency from us to ticks was done using the k_us_to_ticks_ceil32() function. After that commit, it was done with k_us_to_ticks_near32(). ACE has a 100 us exit latency declared in the device tree. A tick is about 83.3 us. Before that commit, the exit latency was calculated as 2 ticks; after the commit, it was calculated as 1 tick. This created a sporadic problem in HDA loopback tests: proper audio was sent to the HDA output link, but silent samples were read from the HDA input link. It seems that running the LL too early, before all hardware parts have completely woken up, results in samples being zeroed by the hardware. This commit restores the correct us to ticks conversion behavior by forcing the use of k_us_to_ticks_ceil32() for conversion. Signed-off-by: Serhiy Katsyuba <serhiy.katsyuba@intel.com>
1 parent b35aba3 commit eed7cd2

File tree

6 files changed

+6
-0
lines changed

6 files changed

+6
-0
lines changed

app/boards/intel_adsp_ace15_mtpm.conf

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -113,6 +113,7 @@ CONFIG_PM_DEVICE=y
113113
CONFIG_PM_DEVICE_RUNTIME=y
114114
CONFIG_PM_DEVICE_SYSTEM_MANAGED=y
115115
CONFIG_PM_DEVICE_POWER_DOMAIN=y
116+
CONFIG_PM_PREWAKEUP_CONV_MODE_CEIL=y
116117
CONFIG_POWER_DOMAIN=y
117118
CONFIG_POWER_DOMAIN_INTEL_ADSP=y
118119

app/boards/intel_adsp_ace20_lnl.conf

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -92,6 +92,7 @@ CONFIG_PM_DEVICE=y
9292
CONFIG_PM_DEVICE_POWER_DOMAIN=y
9393
CONFIG_PM_DEVICE_RUNTIME=y
9494
CONFIG_PM_DEVICE_SYSTEM_MANAGED=y
95+
CONFIG_PM_PREWAKEUP_CONV_MODE_CEIL=y
9596
CONFIG_POWER_DOMAIN=y
9697
CONFIG_POWER_DOMAIN_INTEL_ADSP=y
9798

app/boards/intel_adsp_ace30_ptl.conf

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -91,6 +91,7 @@ CONFIG_PM_DEVICE=y
9191
CONFIG_PM_DEVICE_RUNTIME=y
9292
CONFIG_PM_DEVICE_POWER_DOMAIN=y
9393
CONFIG_PM_DEVICE_SYSTEM_MANAGED=y
94+
CONFIG_PM_PREWAKEUP_CONV_MODE_CEIL=y
9495
CONFIG_POWER_DOMAIN=y
9596
CONFIG_POWER_DOMAIN_INTEL_ADSP=y
9697

app/boards/intel_adsp_ace30_ptl_sim.conf

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -57,6 +57,7 @@ CONFIG_INTEL_ADSP_IPC=y
5757
CONFIG_PM_DEVICE=y
5858
CONFIG_PM_DEVICE_RUNTIME=n
5959
CONFIG_PM_DEVICE_POWER_DOMAIN=n
60+
CONFIG_PM_PREWAKEUP_CONV_MODE_CEIL=y
6061
CONFIG_COMP_KPB=n
6162

6263
CONFIG_CLOCK_CONTROL_ADSP=y

app/boards/intel_adsp_ace30_wcl.conf

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -76,6 +76,7 @@ CONFIG_PM_DEVICE=y
7676
CONFIG_PM_DEVICE_RUNTIME=y
7777
CONFIG_PM_DEVICE_POWER_DOMAIN=y
7878
CONFIG_PM_DEVICE_SYSTEM_MANAGED=y
79+
CONFIG_PM_PREWAKEUP_CONV_MODE_CEIL=y
7980
CONFIG_POWER_DOMAIN=y
8081
CONFIG_POWER_DOMAIN_INTEL_ADSP=y
8182

app/boards/intel_adsp_ace30_wcl_sim.conf

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -56,6 +56,7 @@ CONFIG_INTEL_ADSP_IPC=y
5656
CONFIG_PM_DEVICE=y
5757
CONFIG_PM_DEVICE_RUNTIME=n
5858
CONFIG_PM_DEVICE_POWER_DOMAIN=n
59+
CONFIG_PM_PREWAKEUP_CONV_MODE_CEIL=y
5960
CONFIG_COMP_KPB=n
6061

6162
CONFIG_CLOCK_CONTROL_ADSP=y

0 commit comments

Comments
 (0)