From 277874594bda8567aeb69ba833c095cbf1f72c53 Mon Sep 17 00:00:00 2001
From: MananTank <manantankm@gmail.com>
Date: Wed, 7 Jan 2026 19:26:05 +0000
Subject: [PATCH] SDK: token details screen UI tweaks (#8612)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

<!--

## title your PR with this format: "[SDK/Dashboard/Portal] Feature/Fix: Concise title for the changes"

If you did not copy the branch name from Linear, paste the issue tag here (format is TEAM-0000):

## Notes for the reviewer

Anything important to call out? Be sure to also clarify these in your comments.

## How to test

Unit tests, playground, etc.

-->

<!-- start pr-codex -->

---

## PR-Codex overview
This PR focuses on improving the user interface of the `TokenInfoScreen` component in the `select-token-ui.tsx` file by enhancing loading states, adjusting layout heights, and refining token display logic.

### Detailed summary
- Removed initial loading and token not found states.
- Increased `Container` minHeight from `350px` to `450px`.
- Refactored conditional rendering for token details.
- Maintained structure for displaying token name, symbol, price, market cap, volume, and contract address.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->

<!-- This is an auto-generated comment: release notes by coderabbit.ai -->
## Summary by CodeRabbit

* **Refactor**
  * Consolidated rendering logic for the token information view to centralize pending, not-found, and content states.
  * Reorganized layout so detailed token sections render only when token data is present.
  * Adjusted minimum container height for token information screens in the bridge swap widget.

<sub>✏️ Tip: You can customize this high-level summary in your review settings.</sub>
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
---
 .../ui/Bridge/swap-widget/select-token-ui.tsx | 255 ++++++++----------
 1 file changed, 119 insertions(+), 136 deletions(-)

diff --git a/packages/thirdweb/src/react/web/ui/Bridge/swap-widget/select-token-ui.tsx b/packages/thirdweb/src/react/web/ui/Bridge/swap-widget/select-token-ui.tsx
index f1bc0d67e00..faf99fbdb7a 100644
--- a/packages/thirdweb/src/react/web/ui/Bridge/swap-widget/select-token-ui.tsx
+++ b/packages/thirdweb/src/react/web/ui/Bridge/swap-widget/select-token-ui.tsx
@@ -506,34 +506,6 @@ function TokenInfoScreen(props: {
   });
   const token = tokenQuery.data;
 
-  if (tokenQuery.isPending) {
-    return (
-      <Container
-        flex="column"
-        center="both"
-        expand
-        style={{ minHeight: "350px" }}
-      >
-        <Spinner size="lg" color="secondaryText" />
-      </Container>
-    );
-  }
-
-  if (!token) {
-    return (
-      <Container
-        flex="column"
-        center="both"
-        expand
-        style={{ minHeight: "350px" }}
-      >
-        <Text size="sm" color="secondaryText">
-          Token not found
-        </Text>
-      </Container>
-    );
-  }
-
   const isNativeToken = isNativeTokenAddress(props.tokenAddress);
   const explorerLink = isNativeToken
     ? `https://thirdweb.com/${props.chainId}`
@@ -543,7 +515,7 @@ function TokenInfoScreen(props: {
     <Container
       flex="column"
       expand
-      style={{ minHeight: "350px" }}
+      style={{ minHeight: "450px" }}
       animate="fadein"
     >
       {/* Header */}
@@ -552,125 +524,136 @@ function TokenInfoScreen(props: {
       </Container>
       <Line dashed />
 
-      {/* Content */}
-      <Container flex="column" gap="md" px="md" py="lg">
-        {/* name + icon */}
-        <Container
-          flex="row"
-          style={{
-            justifyContent: "space-between",
-            alignItems: "center",
-          }}
-        >
+      {tokenQuery.isPending ? (
+        <Container flex="column" center="both" expand>
+          <Spinner size="lg" color="secondaryText" />
+        </Container>
+      ) : !token ? (
+        <Container flex="column" center="both" expand>
           <Text size="sm" color="secondaryText">
-            Name
+            Token not found
           </Text>
-
-          <Container flex="row" gap="xxs" center="y">
-            <Img
-              src={token.iconUri || ""}
-              client={props.client}
-              width={iconSize.sm}
-              height={iconSize.sm}
-              style={{
-                borderRadius: radius.full,
-              }}
-              fallback={
-                <Container
-                  style={{
-                    background: `linear-gradient(45deg, white, ${theme.colors.accentText})`,
-                    borderRadius: radius.full,
-                    width: `${iconSize.sm}px`,
-                    height: `${iconSize.sm}px`,
-                  }}
-                />
-              }
-            />
-            <Text
-              size="sm"
-              color="primaryText"
-              weight={500}
-              style={{
-                maxWidth: "200px",
-                whiteSpace: "nowrap",
-              }}
-            >
-              {token.name}
+        </Container>
+      ) : (
+        <Container flex="column" gap="md" px="md" py="lg">
+          {/* name + icon */}
+          <Container
+            flex="row"
+            style={{
+              justifyContent: "space-between",
+              alignItems: "center",
+            }}
+          >
+            <Text size="sm" color="secondaryText">
+              Name
             </Text>
+
+            <Container flex="row" gap="xxs" center="y">
+              <Img
+                src={token.iconUri || ""}
+                client={props.client}
+                width={iconSize.sm}
+                height={iconSize.sm}
+                style={{
+                  borderRadius: radius.full,
+                }}
+                fallback={
+                  <Container
+                    style={{
+                      background: `linear-gradient(45deg, white, ${theme.colors.accentText})`,
+                      borderRadius: radius.full,
+                      width: `${iconSize.sm}px`,
+                      height: `${iconSize.sm}px`,
+                    }}
+                  />
+                }
+              />
+              <Text
+                size="sm"
+                color="primaryText"
+                weight={500}
+                style={{
+                  maxWidth: "200px",
+                  whiteSpace: "nowrap",
+                }}
+              >
+                {token.name}
+              </Text>
+            </Container>
           </Container>
-        </Container>
 
-        {/* symbol */}
-        <TokenInfoRow label="Symbol" value={token.symbol} />
-
-        {/* price */}
-        {"prices" in token && (
-          <TokenInfoRow
-            label="Price"
-            value={
-              token.prices[props.currency]
-                ? formatCurrencyAmount(
-                    props.currency,
-                    token.prices[props.currency] as number,
-                  )
-                : "N/A"
-            }
-          />
-        )}
+          {/* symbol */}
+          <TokenInfoRow label="Symbol" value={token.symbol} />
+
+          {/* price */}
+          {"prices" in token && (
+            <TokenInfoRow
+              label="Price"
+              value={
+                token.prices[props.currency]
+                  ? formatCurrencyAmount(
+                      props.currency,
+                      token.prices[props.currency] as number,
+                    )
+                  : "N/A"
+              }
+            />
+          )}
 
-        {/* market cap */}
-        {!!token.marketCapUsd && (
-          <TokenInfoRow
-            label="Market Cap"
-            value={formatCurrencyAmount(props.currency, token.marketCapUsd)}
-          />
-        )}
+          {/* market cap */}
+          {!!token.marketCapUsd && (
+            <TokenInfoRow
+              label="Market Cap"
+              value={formatCurrencyAmount(props.currency, token.marketCapUsd)}
+            />
+          )}
 
-        {/* volume 24h */}
-        {!!token.volume24hUsd && (
-          <TokenInfoRow
-            label="Volume (24h)"
-            value={formatCurrencyAmount(props.currency, token.volume24hUsd)}
-          />
-        )}
+          {/* volume 24h */}
+          {!!token.volume24hUsd && (
+            <TokenInfoRow
+              label="Volume (24h)"
+              value={formatCurrencyAmount(props.currency, token.volume24hUsd)}
+            />
+          )}
 
-        {/* address + link */}
-        <Container
-          flex="row"
-          style={{
-            justifyContent: "space-between",
-            alignItems: "center",
-          }}
-        >
-          <Text size="sm" color="secondaryText">
-            Contract Address
-          </Text>
+          {/* address + link */}
+          <Container
+            flex="row"
+            style={{
+              justifyContent: "space-between",
+              alignItems: "center",
+            }}
+          >
+            <Text size="sm" color="secondaryText">
+              Contract Address
+            </Text>
 
-          <Container flex="row" gap="3xs" center="y">
-            {!isNativeToken && (
-              <CopyIcon
-                text={props.tokenAddress}
-                iconSize={13}
-                tip="Copy Address"
-              />
-            )}
+            <Container flex="row" gap="3xs" center="y">
+              {!isNativeToken && (
+                <CopyIcon
+                  text={props.tokenAddress}
+                  iconSize={13}
+                  tip="Copy Address"
+                />
+              )}
 
-            <Link
-              href={explorerLink}
-              target="_blank"
-              rel="noreferrer"
-              color="accentText"
-              hoverColor="primaryText"
-              weight={500}
-              size="sm"
-            >
-              {isNativeToken
-                ? "Native Currency"
-                : shortenAddress(props.tokenAddress)}
-            </Link>
+              <Link
+                href={explorerLink}
+                target="_blank"
+                rel="noreferrer"
+                color="accentText"
+                hoverColor="primaryText"
+                weight={500}
+                size="sm"
+              >
+                {isNativeToken
+                  ? "Native Currency"
+                  : shortenAddress(props.tokenAddress)}
+              </Link>
+            </Container>
           </Container>
         </Container>
-      </Container>
+      )}
     </Container>
   );
 }