chore: Create helper func to know if the monitoring port is configured (#4446)

Signed-off-by: Thomas Poignant <thomas.poignant@gofeatureflag.org>

Author: thomaspoignant

cmd/relayproxy/api/server.go

@@ -144,7 +144,7 @@ func (s *Server) startUnixSocketServer(ctx context.Context) {
 	}
 
 	// Start a http server for monitoring if monitoringport is configured
-	if s.monitoringEcho != nil && s.config.GetMonitoringPort(s.zapLog) > 0 {
+	if s.isMonitoringPortConfigured() {
 		go s.startMonitoringServer()
 		defer func() { _ = s.monitoringEcho.Close() }()
 	}
@@ -176,7 +176,7 @@ func (s *Server) startUnixSocketServer(ctx context.Context) {
 // startAsHTTPServer launch the API server
 func (s *Server) startAsHTTPServer() {
 	// starting the monitoring server on a different port if configured
-	if s.monitoringEcho != nil {
+	if s.isMonitoringPortConfigured() {
 		go s.startMonitoringServer()
 		defer func() { _ = s.monitoringEcho.Close() }()
 	}
@@ -238,3 +238,8 @@ func (s *Server) Stop(ctx context.Context) {
 		}
 	}
 }
+
+// isMonitoringPortConfigured checks if the monitoring port is configured.
+func (s *Server) isMonitoringPortConfigured() bool {
+	return s.monitoringEcho != nil && s.config.GetMonitoringPort(s.zapLog) > 0
+}