thecl: fix warnings (fallthrough and unused parameter)

Author: DankRank

thecl/ecsparse.y

@@ -1467,6 +1467,7 @@ Address:
             switch (type) {
                 case 'z':
                     $$->is_inline_string = true;
+                    /* fallthrough */
                 case 'S':
                     $$->value.val.S = var_stack(state, state->current_sub, $1, 'S');
                     break;

thecl/expr.c

@@ -188,20 +188,21 @@ expr_get_by_symbol(
     switch (engine_version(version)) {
         default:
         case VER_POST_TH13:
-            ret = expr_get_by_symbol_from_table(th13_expressions, symbol);
-            if (ret) break;
+            if ((ret = expr_get_by_symbol_from_table(th13_expressions, symbol))) break;
+            /* fallthrough */
         case VER_POST_TH125:
-            ret = expr_get_by_symbol_from_table(th125_expressions, symbol);
-            if (ret) break;
+            if ((ret = expr_get_by_symbol_from_table(th125_expressions, symbol))) break;
+            /* fallthrough */
         case VER_POST_ALCOSTG:
-            ret = expr_get_by_symbol_from_table(alcostg_expressions, symbol);
-            if (ret) break;
+            if ((ret = expr_get_by_symbol_from_table(alcostg_expressions, symbol))) break;
+            /* fallthrough */
         case VER_POST_TH10:
             ret = expr_get_by_symbol_from_table(th10_expressions, symbol);
             break;
         case VER_PRE_TH10:
         case VER_PRE_TH8:
             ret = expr_get_by_symbol_from_table(th06_expressions, symbol);
+            break;
     }
 
     return ret;
@@ -231,20 +232,21 @@ expr_get_by_id(
     switch (engine_version(version)) {
         default:
         case VER_POST_TH13:
-            ret = expr_get_by_id_from_table(th13_expressions, id);
-            if (ret) break;
+            if ((ret = expr_get_by_id_from_table(th13_expressions, id))) break;
+            /* fallthrough */
         case VER_POST_TH125:
-            ret = expr_get_by_id_from_table(th125_expressions, id);
-            if (ret) break;
+            if ((ret = expr_get_by_id_from_table(th125_expressions, id))) break;
+            /* fallthrough */
         case VER_POST_ALCOSTG:
-            ret = expr_get_by_id_from_table(alcostg_expressions, id);
-            if (ret) break;
+            if ((ret = expr_get_by_id_from_table(alcostg_expressions, id))) break;
+            /* fallthrough */
         case VER_POST_TH10:
             ret = expr_get_by_id_from_table(th10_expressions, id);
             break;
         case VER_PRE_TH10:
         case VER_PRE_TH8:
             ret = expr_get_by_id_from_table(th06_expressions, id);
+            break;
     }
 
     return ret;

thecl/thecl06.c

@@ -234,7 +234,7 @@ th06_stringify_param(
                                 val = (int)floorf(param->value.val.f);
                                 break;
                         }
-                        
+
                         seqmap_entry_t * ent = seqmap_get(g_eclmap->gvar_names, val);
                         if (ent) {
                             snprintf(temp, 256, "%c%s", param->value.type == 'f' ? '%' : '$', ent->value);
@@ -1424,6 +1424,7 @@ th06_timeline_instr_size(
                     ret += utf8_to_cp932_len(param->value.val.z);
                     break;
                 }
+                /* fallthrough */
             default: {
                 value_t v = param->value;
                 v.type = param->type;
@@ -1570,6 +1571,7 @@ th06_serialize_data(
     size_t data_size,
     bool is_timeline)
 {
+    (void)instr; // FIXME: maybe remove this unused parameter?
     value_t v;
     switch (param->type) {
         case 'n':

thecl/thecl10.c

@@ -2082,6 +2082,7 @@ th10_instr_size(
                     // filled in with values once the sub is inlined.
                     return 0;
                 }
+                /* fallthrough */
             default:
                 ret += value_size(&param->value);
                 break;