Merge pull request #78 from csoneson/bugfix-nonmatching-dimnames

Bugfix nonmatching dimnames

Author: stemangiola

R/dplyr_methods.R

@@ -1417,7 +1417,7 @@ pull.SummarizedExperiment <- function(.data, var=-1, name=NULL, ...) {
         warning( 
           "tidySummarizedExperiment says: the assays in your SummarizedExperiment have column names, 
   but their order is not the same. Pulling assays can return data in a order you don't expect. 
-  To avoid unwanted behaviour it is highly reccomended to have assays with the same order of colnames and rownames" 
+  To avoid unwanted behaviour it is highly recommended to have assays with the same order of colnames and rownames" 
         )
 
         # reorder assay colnames before printing

R/tibble_methods.R

@@ -88,8 +88,8 @@ as_tibble.SummarizedExperiment <- function(x, ...,
 
     # If I want to return all columns
     count_info %>%
-      inner_join(sample_info, by=s_(x)$name) %>%
-      inner_join(gene_info, by=f_(x)$name) %>%
+      full_join(sample_info, by=s_(x)$name) %>%
+      full_join(gene_info, by=f_(x)$name) %>%
       when(nrow(range_info) > 0 ~ (.) %>% left_join(range_info) %>% suppressMessages(), ~ (.)) 
 
   # This function outputs a tibble after subsetting the columns