From 6df4c97de7577a67f3e85f82e6321c67d0c9c7e3 Mon Sep 17 00:00:00 2001 From: Kiran Thomas Date: Sat, 25 Jan 2025 19:50:24 -0600 Subject: [PATCH] chore: reverse list for eachUrlPart --- README.md | 4 +--- gradle.properties | 4 ++-- .../java/se/bjurr/gitchangelog/api/helpers/Helpers.java | 2 ++ .../api/TemplatesTest.testEachUrlPart.approved.txt | 9 ++------- src/test/resources/templatetest/testEachUrlPart.mustache | 4 +--- 5 files changed, 8 insertions(+), 15 deletions(-) diff --git a/README.md b/README.md index 2b08065..2665fbc 100644 --- a/README.md +++ b/README.md @@ -167,9 +167,7 @@ Some [helpers](/src/main/java/se/bjurr/gitchangelog/api/helpers) are implemented Loop each part of the URL. ```hbs -{{#eachUrlPart .}} -{{@index}}: {{.}} -{{/eachUrlPart}} +https://gitlab.com/{{#eachUrlPart .}}{{#if @first}}{{else}}{{.}}/{{/if}}{{/eachUrlPart}} ``` ### `ifReleaseTag ` diff --git a/gradle.properties b/gradle.properties index 816f917..d8d1789 100644 --- a/gradle.properties +++ b/gradle.properties @@ -1,7 +1,7 @@ # -#Sat Jan 18 07:59:25 CET 2025 +#Sat Jan 25 19:50:49 CST 2025 description='Library for parsing report files from static code analysis' group=se.bjurr.gitchangelog sourceCompatibility=17 targetCompatibility=17 -version=2.5.0 +version=2.5.1 diff --git a/src/main/java/se/bjurr/gitchangelog/api/helpers/Helpers.java b/src/main/java/se/bjurr/gitchangelog/api/helpers/Helpers.java index de37905..630d1b0 100644 --- a/src/main/java/se/bjurr/gitchangelog/api/helpers/Helpers.java +++ b/src/main/java/se/bjurr/gitchangelog/api/helpers/Helpers.java @@ -28,6 +28,7 @@ import com.github.jknack.handlebars.Options.Buffer; import com.github.jknack.handlebars.helper.EachHelper; import java.io.IOException; +import java.util.Collections; import java.util.List; import java.util.Map; import java.util.TreeMap; @@ -242,6 +243,7 @@ public static Map> getAll() { helpers.put( "eachUrlPart", (final Changelog changelog, final Options options) -> { + Collections.reverse(changelog.getUrlParts()); return each(options, changelog.getUrlParts()); }); return helpers; diff --git a/src/test/java/se/bjurr/gitchangelog/api/TemplatesTest.testEachUrlPart.approved.txt b/src/test/java/se/bjurr/gitchangelog/api/TemplatesTest.testEachUrlPart.approved.txt index 518d19e..9acc12c 100644 --- a/src/test/java/se/bjurr/gitchangelog/api/TemplatesTest.testEachUrlPart.approved.txt +++ b/src/test/java/se/bjurr/gitchangelog/api/TemplatesTest.testEachUrlPart.approved.txt @@ -3,9 +3,7 @@ template: ownerName: {{ownerName}} repoName: {{repoName}} urlParts: {{urlParts}} -{{#eachUrlPart .}} -{{@index}}: {{.}} -{{/eachUrlPart}} +https://github.com/{{#eachUrlPart .}}{{#if @first}}{{else}}{{.}}/{{/if}}{{/eachUrlPart}} --------------------------------------------- @@ -72,10 +70,7 @@ changelog: ownerName: tomasbjerre repoName: git-changelog-lib urlParts: [git-changelog-lib, tomasbjerre, git@github.com] -0: git-changelog-lib -1: tomasbjerre -2: git@github.com - +https://github.com/tomasbjerre/git-changelog-lib/ --------------------------------------------- diff --git a/src/test/resources/templatetest/testEachUrlPart.mustache b/src/test/resources/templatetest/testEachUrlPart.mustache index d4fe6ed..c205243 100644 --- a/src/test/resources/templatetest/testEachUrlPart.mustache +++ b/src/test/resources/templatetest/testEachUrlPart.mustache @@ -1,6 +1,4 @@ ownerName: {{ownerName}} repoName: {{repoName}} urlParts: {{urlParts}} -{{#eachUrlPart .}} -{{@index}}: {{.}} -{{/eachUrlPart}} \ No newline at end of file +https://github.com/{{#eachUrlPart .}}{{#if @first}}{{else}}{{.}}/{{/if}}{{/eachUrlPart}}