Merge pull request #49 from jpetso/extra_warnings

More compiler warning maintenance, in addition to @thrimbor and @GTValentine patches.

Author: jpetso

CMakeLists.txt

@@ -21,7 +21,7 @@ if (MSVC)
   # fine for anything except ancient MSVC versions.
   set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} /W4")
 else()
-  set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wall -pedantic")
+  set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wall -Wextra -pedantic")
 
   # CMake versions before 3.1 do not understand CMAKE_CXX_STANDARD.
   # Remove this block once CMake >=3.1 has fixated in the ecosystem.

cppcodec/base32_crockford.hpp

@@ -63,7 +63,7 @@ class base32_crockford_base
 
     static CPPCODEC_ALWAYS_INLINE constexpr bool generates_padding() { return false; }
     static CPPCODEC_ALWAYS_INLINE constexpr bool requires_padding() { return false; }
-    static CPPCODEC_ALWAYS_INLINE constexpr bool is_padding_symbol(char /*c*/) { return false; }
+    static CPPCODEC_ALWAYS_INLINE constexpr bool is_padding_symbol(char) { return false; }
     static CPPCODEC_ALWAYS_INLINE constexpr bool is_eof_symbol(char c) { return c == '\0'; }
 
     static CPPCODEC_ALWAYS_INLINE constexpr bool should_ignore(char c) {

cppcodec/data/access.hpp

@@ -161,7 +161,7 @@ class direct_data_access_result_state
         // Conditional code paths are slow so we only do it once, at the start.
         m_buffer = result.data();
     }
-    CPPCODEC_ALWAYS_INLINE void put(Result& /*result*/, char c)
+    CPPCODEC_ALWAYS_INLINE void put(Result&, char c)
     {
         m_buffer[m_offset++] = c;
     }

cppcodec/detail/stream_codec.hpp

@@ -203,7 +203,7 @@ struct index_if_in_alphabet {
 };
 template <typename CodecVariant, alphabet_index_t InvalidIdx>
 struct index_if_in_alphabet<CodecVariant, InvalidIdx, 0> { // terminating specialization
-    static CPPCODEC_ALWAYS_INLINE constexpr alphabet_index_t for_symbol(char /*symbol*/)
+    static CPPCODEC_ALWAYS_INLINE constexpr alphabet_index_t for_symbol(char)
     {
         return InvalidIdx;
     }

cppcodec/hex_lower.hpp

@@ -59,7 +59,7 @@ class hex_lower
     static CPPCODEC_ALWAYS_INLINE constexpr bool generates_padding() { return false; }
     // FIXME: doesn't require padding, but requires a multiple of the encoded block size (2)
     static CPPCODEC_ALWAYS_INLINE constexpr bool requires_padding() { return false; }
-    static CPPCODEC_ALWAYS_INLINE constexpr bool is_padding_symbol(char /*c*/) { return false; }
+    static CPPCODEC_ALWAYS_INLINE constexpr bool is_padding_symbol(char) { return false; }
     static CPPCODEC_ALWAYS_INLINE constexpr bool is_eof_symbol(char c) { return c == '\0'; }
 
     // Sometimes hex strings include whitespace, but this variant forbids it.

cppcodec/hex_upper.hpp

@@ -59,7 +59,7 @@ class hex_upper
     static CPPCODEC_ALWAYS_INLINE constexpr bool generates_padding() { return false; }
     // FIXME: doesn't require padding, but requires a multiple of the encoded block size (2)
     static CPPCODEC_ALWAYS_INLINE constexpr bool requires_padding() { return false; }
-    static CPPCODEC_ALWAYS_INLINE constexpr bool is_padding_symbol(char /*c*/) { return false; }
+    static CPPCODEC_ALWAYS_INLINE constexpr bool is_padding_symbol(char) { return false; }
     static CPPCODEC_ALWAYS_INLINE constexpr bool is_eof_symbol(char c) { return c == '\0'; }
 
     // Sometimes hex strings include whitespace, but this variant forbids it.